Noise

Merge lp://staging/~hyuchia/noise/fix-1226027 into lp://staging/~elementary-apps/noise/trunk

  1. fix-1226027
  2. Merge into trunk
Proposed by Diego Islas Ocampo
Status: Merged
Merge reported by: Jeremy Wootten
Merged at revision: not available
Proposed branch: lp://staging/~hyuchia/noise/fix-1226027
Merge into: lp://staging/~elementary-apps/noise/trunk
Diff against target: 291 lines (+40/-36)
2 files modified
src/Dialogs/PreferencesWindow.vala (+14/-12)
src/LibraryWindow.vala (+26/-24)
To merge this branch: bzr merge lp://staging/~hyuchia/noise/fix-1226027
Reviewer Review Type Date Requested Status
Jeremy Wootten code, function Approve
Review via email: mp+318665@code.staging.launchpad.net

Commit message

Remember selected music folder (lp:1226027)

Description of the change

Fix behavior where selecting a new folder from the FileChooser in the Preferences window would not be applied.

To post a comment you must log in.
Revision history for this message
Jeremy Wootten (jeremywootten) wrote :

Apart from the small formatting error indicated inline, this works as expected.

review: Needs Fixing
Revision history for this message
Jeremy Wootten (jeremywootten) :
review: Needs Fixing (code format)
lp://staging/~hyuchia/noise/fix-1226027 updated
2052. By Diego Islas Ocampo

Add space before function call

Revision history for this message
Diego Islas Ocampo (hyuchia) wrote :

Just added the space :)

Revision history for this message
Jeremy Wootten (jeremywootten) wrote :

Approving code and function. There is no impact on the UI.

review: Approve (code, function)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches