AppCenter

Merge lp://staging/~hyuchia/appcenter/release-info into lp://staging/~elementary-apps/appcenter/appcenter

  1. release-info
  2. Merge into appcenter
Proposed by Diego Islas Ocampo
Status: Merged
Approved by: Jeremy Wootten
Approved revision: 413
Merged at revision: 410
Proposed branch: lp://staging/~hyuchia/appcenter/release-info
Merge into: lp://staging/~elementary-apps/appcenter/appcenter
Diff against target: 103 lines (+58/-29)
2 files modified
data/CMakeLists.txt (+1/-1)
data/appcenter.appdata.xml.in (+57/-28)
To merge this branch: bzr merge lp://staging/~hyuchia/appcenter/release-info
Reviewer Review Type Date Requested Status
Jeremy Wootten code Approve
Review via email: mp+318870@code.staging.launchpad.net

Commit message

* Add release information to the AppData.xml

Description of the change

Add release information to the AppData.xml file for appcenter support.

To post a comment you must log in.
Revision history for this message
Jeremy Wootten (jeremywootten) wrote :

Misspelling noted inline

lp://staging/~hyuchia/appcenter/release-info updated
411. By Diego Islas Ocampo

Fix typo

Revision history for this message
Jeremy Wootten (jeremywootten) wrote :

appstream-utils validate gave the following errors:

• tag-missing : <translation> not specified
• tag-invalid : <project_group> is not valid
• style-invalid : Not enough <screenshot> tags
• style-invalid : <ul> cannot start a description [(null)]
• style-invalid : <li> is too short [Minor Bug Fixes]
• style-invalid : Not enough <p> tags for a good description

The last three do not occur in trunk, however validate-relax does not give these last three errors (only gives tag missing error) so they may not be important.

lp://staging/~hyuchia/appcenter/release-info updated
412. By Diego Islas Ocampo

Add release description paragraphs

413. By Diego Islas Ocampo

Update AppData installation path

Revision history for this message
Jeremy Wootten (jeremywootten) wrote :

Passes appstreamcli validate (with minor warning regarding one of the translations).
I am not sure whether leaving the old version in /usr/share/appdata matters - maybe the package can deal with that?

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches