Merge lp://staging/~hyperair/ubuntu/quantal/dput/sftp-progress-indicator into lp://staging/ubuntu/quantal/dput

Proposed by Chow Loong Jin
Status: Merged
Merged at revision: 29
Proposed branch: lp://staging/~hyperair/ubuntu/quantal/dput/sftp-progress-indicator
Merge into: lp://staging/ubuntu/quantal/dput
Diff against target: 96 lines (+35/-10)
3 files modified
debian/changelog (+10/-0)
debian/control (+1/-1)
sftp.py (+24/-9)
To merge this branch: bzr merge lp://staging/~hyperair/ubuntu/quantal/dput/sftp-progress-indicator
Reviewer Review Type Date Requested Status
Martin Pitt Approve
Review via email: mp+112934@code.staging.launchpad.net

Description of the change

Give dput's sftp method a progress indicator, and drop trailing whitespaces in sftp.py. Also lower the suggests from bzr to python-bzrlib, since we don't need the full bzr just for sftp support.

To post a comment you must log in.
33. By Chow Loong Jin

Fix typo in changelog (bzr was in suggests, not depends)

Revision history for this message
Martin Pitt (pitti) wrote :

Hello Chow, thanks for working on this! Can you please forward this to Debian as well? In particular the whitespace fixes seem to be something that's rather hard/low-benefit to maintain on the Ubuntu side, and Debian also has some places with sftp upload (DELAYED, for example).

Revision history for this message
Martin Pitt (pitti) wrote :

Chow pointed out that sftp.py is Ubuntu only ATM. Thanks for this!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches