Alarm Clock Applet

Merge lp://staging/~hyperair/alarm-clock/set-indicator-title into lp://staging/~joh/alarm-clock/trunk

set-indicator-title
Merge into trunk

Proposed by Chow Loong Jin on 2012-04-16

Status:	Merged
Approved by:	Johannes H. Jensen on 2012-05-06
Approved revision:	220
Merge reported by:	Johannes H. Jensen
Merged at revision:	not available
Proposed branch:	lp://staging/~hyperair/alarm-clock/set-indicator-title
Merge into:	lp://staging/~joh/alarm-clock/trunk
Diff against target:	35 lines (+10/-1) 2 files modified configure.ac (+7/-1) src/ui.c (+3/-0)
To merge this branch:	bzr merge lp://staging/~hyperair/alarm-clock/set-indicator-title
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Johannes H. Jensen		2012-04-16	Approve on 2012-05-06
Review via email: mp+102207@code.staging.launchpad.net

Description of the change

Set the application indicator title so that we get something descriptive for the menu title in the Ubuntu Precise HUD:

i.e. Rather than
> Show Alarms

Alarm > Show Alarms

Revision history for this message

Johannes H. Jensen (joh) wrote on 2012-04-17:

Hmm, I'm not entirely sure where this would end up, but shouldn't it rather be "Alarm Clock" instead of just "Alarm"? Screenshot would be appreciated :)

Revision history for this message

Chow Loong Jin (hyperair) wrote on 2012-04-17:

On 18/04/2012 02:19, Johannes H. Jensen wrote:
> Hmm, I'm not entirely sure where this would end up, but shouldn't it rather
> be "Alarm Clock" instead of just "Alarm"? Screenshot would be appreciated :)

Sure, here you go:

http://people.ubuntu.com/~hyperair/alarm-clock-applet-screenshots.tar.xz

--
Kind regards,
Loong Jin

Revision history for this message

Johannes H. Jensen (joh) wrote on 2012-04-17:

On Tue, Apr 17, 2012 at 20:34, Chow Loong Jin <email address hidden> wrote:
>
> Sure, here you go:
>
> http://people.ubuntu.com/~hyperair/alarm-clock-applet-screenshots.tar.xz
>

Thank you!

(The link gave a 404, but I assume you meant
http://people.ubuntu.com/~hyperair/alarm-clock-screenshots.tar.xz)

I haven't followed Ubuntu development lately, but from what I can gather
from the screenshot, "Alarm Clock" is better suited.

- Johannes

lp://staging/~hyperair/alarm-clock/set-indicator-title updated on 2012-04-18

219. By Chow Loong Jin on 2012-04-18

Amend indicator title to Alarm Clock instead

220. By Chow Loong Jin on 2012-04-18

Check for appindicator-0.1 >= 0.4.90

app_indicator_set_title() was only introduced in appindicator 0.4.90, so check
for that version and only call this function if we have a new enough version

Revision history for this message

Johannes H. Jensen (joh) on 2012-05-06:

review: Approve