Merge lp://staging/~huwshimi/launchpad/sidebar-cleanup into lp://staging/launchpad
Proposed by
Huw Wilkins
| Status: | Merged |
|---|---|
| Approved by: | Curtis Hovey |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 15603 |
| Proposed branch: | lp://staging/~huwshimi/launchpad/sidebar-cleanup |
| Merge into: | lp://staging/launchpad |
| Diff against target: |
711 lines (+162/-177) 16 files modified
lib/canonical/launchpad/icing/css/components/sidebar_portlets.css (+42/-16) lib/canonical/launchpad/icing/style.css (+0/-17) lib/lp/answers/browser/questiontarget.py (+1/-1) lib/lp/app/templates/navigationmenu-related-pages.pt (+1/-1) lib/lp/blueprints/browser/specificationtarget.py (+1/-1) lib/lp/bugs/javascript/tests/test_bugtarget_portlet_bugtags.js (+8/-8) lib/lp/bugs/stories/bug-tags/xx-tags-on-bug-listings-page.txt (+1/-1) lib/lp/bugs/stories/bugs/xx-portlets-bug-milestones.txt (+4/-2) lib/lp/bugs/stories/bugs/xx-portlets-bug-series.txt (+16/-8) lib/lp/bugs/templates/buglisting-default.pt (+1/-1) lib/lp/bugs/templates/bugtarget-portlet-bugfilters-content.pt (+43/-76) lib/lp/bugs/templates/bugtarget-portlet-bugtags.pt (+6/-8) lib/lp/bugs/templates/bugtarget-portlet-tags-content.pt (+7/-8) lib/lp/bugs/templates/bugtask-portlet-milestonebugs.pt (+9/-12) lib/lp/bugs/templates/bugtask-portlet-seriesbugs.pt (+9/-12) lib/lp/bugs/tests/bug.py (+13/-5) |
| To merge this branch: | bzr merge lp://staging/~huwshimi/launchpad/sidebar-cleanup |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Curtis Hovey (community) | code | Approve | |
|
Review via email:
|
|||
Commit message
Improved sidebar CSS, HTML and UI.
Description of the change
This branch cleans up a lot of our sidebar HTML/CSS. It makes the UI more consistent, it makes the HTML/CSS more consistent and removes code.
In this branch:
- Sidebar CSS all lives in one file now (sidebar_
- Removed some inline styles and replaced with consistent classes for the involvement portlet.
- Standardised the UI, HTML and CSS of portlets with counts (status counts, tags, series, milestones).
- Fixed some spacing issues with CVE reports and tags porlets.
- Renamed a few css files.
To post a comment you must log in.
Revision history for this message
| Huw Wilkins (huwshimi) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Thank you for this clean up. I think some of your changes overlap with bug #244384 "portletBody and portletContent are obsolete". I think you can remove the portletBody tags from the lines you modified. Maybe you want to remove all of them.