Merge lp://staging/~huwshimi/juju-gui/new-header into lp://staging/juju-gui/experimental
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://staging/~huwshimi/juju-gui/new-header |
| Merge into: | lp://staging/juju-gui/experimental |
| Diff against target: |
409 lines (+135/-145) 9 files modified
app/app.js (+1/-1) app/index.html (+29/-40) app/views/service.js (+1/-1) app/views/utils.js (+1/-1) lib/views/base/header.less (+94/-0) lib/views/stylesheet.less (+5/-98) test/test_application_notifications.js (+1/-1) test/test_environment_view.js (+1/-1) test/test_notifications.js (+2/-2) |
| To merge this branch: | bzr merge lp://staging/~huwshimi/juju-gui/new-header |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Juju GUI Hackers | Pending | ||
|
Review via email:
|
|||
Commit message
Updated header to match the new design.
Description of the change
CHANGES:
Moved header css to own file.
Renamed classes and removed HTML that were specific Bootstrap.
Updated tests.
Set main header to use an id as there should only ever be one.
Updated colours and positioning to new design.
Added new logo file. Will update this again when we have an SVG of it.
Removed unnecessary HTML and made more semantically correct.
Re-ordered CSS to make more sense with the corresponding HTML and made it
more consistent.
Removed old image files.
TODO:
The new header is not yet responsive. That probably isn't worth doing until
we've moved the charm panel and removed the link and search from the header.
The notification button still uses Bootstrap and has not yet been styled
as per the new design.
Unmerged revisions
- 464. By Huw Wilkins
-
Styled header to match new design.
