Merge lp://staging/~hrvojem/percona-server/bug1059987-5.5 into lp://staging/percona-server/5.5
Proposed by
Hrvoje Matijakovic
Status: | Merged | ||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Approved by: | Hrvoje Matijakovic | ||||||||||||||||||||||||
Approved revision: | no longer in the source branch. | ||||||||||||||||||||||||
Merged at revision: | 466 | ||||||||||||||||||||||||
Proposed branch: | lp://staging/~hrvojem/percona-server/bug1059987-5.5 | ||||||||||||||||||||||||
Merge into: | lp://staging/percona-server/5.5 | ||||||||||||||||||||||||
Diff against target: |
176 lines (+75/-17) 6 files modified
doc/source/index.rst (+1/-0) doc/source/performance/binary_group_commit.rst (+45/-0) doc/source/performance/innodb_fast_checksum.rst (+1/-1) doc/source/performance/innodb_numa_support.rst (+6/-6) doc/source/reliability/innodb_corrupt_table_action.rst (+11/-9) doc/source/scalability/innodb_io_55.rst (+11/-1) |
||||||||||||||||||||||||
To merge this branch: | bzr merge lp://staging/~hrvojem/percona-server/bug1059987-5.5 | ||||||||||||||||||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alexey Kopytov (community) | Approve | ||
Review via email: mp+148467@code.staging.launchpad.net |
To post a comment you must log in.
- "additional writes (*fsync()* system calls) that are needed to
store the additional information on the disk"
=>
"additional *fsync()* system calls on both binary and XtraDB REDO
log when committing a transaction"
- "a single *fsync()* to write the information to the storage for
several transactions that are running concurrently"
=>
"a single *fsync()* calls to force data to the storage for multiple
concurrently committing transactions"
- s/multi- concurrent/ write-concurren t/
- "Pass corruptions of user tables as ``corrupt table`` instead of ON_USAGE) instead of crashing with an
crashing itself"
=>
"Return error 1194 (ER_CRASHED_
assertion failure"
- "All file I/O for the datafile after detected as corrupt is
disabled, except for the deletion."
=>
"Once corruption is detected, access to the corrupted tablespace is
disabled. The only allowed operation on a corrupted tablespace is
DROP TABLE. The only exception to this rule is when the option value
is ``salvage`` (see below)."
- "When the default value is used |InnoDB| will stop the server if it
finds a checksum mismatch on the tables."
=>
"With the default value |XtraDB| will intentionally crash the
server with an assertion failure as it would normally do when
detecting corrupted data in a single-table tablespace."
- "It still exists as :variable: `innodb_ pass_corrupt_ table`" `innodb_ pass_corrupt_ table`"
=>
"The option name was :variable:
- s/If ``warn`` values/If the ``warn`` value/
- "Value ``salvage`` can be used to dump a table which has a few pages
corrupt, by skipping over them. This value is intended for Data
Recovery rather than everyday use."
=>
"When the option value is ``salvage``, |XtraDB| allows read access
to a corrupted tablespace, but ignores corrupted pages".
- I think we can avoid that note about innodb_ buffer_ pool_populate' s
default value being sometimes displayed as ON or OFF. That remark
applies to all boolean variables starting with "innodb_". Such as:
- innodb_ track_changed_ pages buffer_ pool_shm_ key (which is in fact incorrectly stats_auto_ update use_sys_ stats_table
- innodb_
documented as Boolean, but the feature itself is deprecated, so
we probably don't care)
- innodb_
- innodb_
- etc., etc.
There are multiple upstream issues here related to boolean
variables inconsistencies here. The best thing we can do here is
probably just document possible values for all XtraDB boolean
variables as 0/1.
- explanations for innodb_ fast_checksum should make it clear that the checksum_ algorithm feature in MySQL 5.6 makes it redundant.
feature has been marked deprecated in Percona Server 5.1/5.5 and
will not be available in Percona Server 5.6, because the
innodb_
- s/Only difference is the different default value/The only
difference is the default value/
- the MP also links to bug #996545 adaptive_ flushing_ method= estimate and innodb_ io_capacity" ,
"innodb_
but I don't see any relevant changes in the diff?