Merge lp://staging/~hrvojem/percona-pam-for-mysql/dialog-intro into lp://staging/percona-pam-for-mysql

Proposed by Hrvoje Matijakovic
Status: Merged
Approved by: Laurynas Biveinis
Approved revision: no longer in the source branch.
Merged at revision: 24
Proposed branch: lp://staging/~hrvojem/percona-pam-for-mysql/dialog-intro
Merge into: lp://staging/percona-pam-for-mysql
Diff against target: 47 lines (+21/-3)
3 files modified
.bzrignore (+1/-0)
doc/source/glossary.rst (+1/-1)
doc/source/intro.rst (+19/-2)
To merge this branch: bzr merge lp://staging/~hrvojem/percona-pam-for-mysql/dialog-intro
Reviewer Review Type Date Requested Status
Laurynas Biveinis (community) Approve
Review via email: mp+94546@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

The text looks good, couple of nitpicks:

Line 29: s/plugin.This/plugin. This
Line 43: "mysqlclient", does it mean "MySQL client" or "libmysqlclient"?
Line 43: s/1/one

review: Needs Fixing
Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

s/it support/it supports

OK with that change, thank you

review: Approve
24. By Hrvoje Matijakovic

* dialog description added with list of features
* doc/build/ added to .bzrignore

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches