Merge lp://staging/~hopem/openstack-charm-testing/update-readme-tempest into lp://staging/openstack-charm-testing

Proposed by Edward Hope-Morley
Status: Rejected
Rejected by: Ryan Beisner
Proposed branch: lp://staging/~hopem/openstack-charm-testing/update-readme-tempest
Merge into: lp://staging/openstack-charm-testing
Diff against target: 31 lines (+8/-6)
1 file modified
README (+8/-6)
To merge this branch: bzr merge lp://staging/~hopem/openstack-charm-testing/update-readme-tempest
Reviewer Review Type Date Requested Status
Ryan Beisner Disapprove
Review via email: mp+264972@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Ryan Beisner (1chb1n) wrote :

Actually, I was planning on moving to venv usage with regard to tempest, as sudo pip installing is generally dangerous from the pip vs deb package version conflict perspective.

Can you work in venv along with your new tox approach?

Revision history for this message
Ryan Beisner (1chb1n) wrote :

I believe we address this similarly with a different merge.

review: Disapprove

Unmerged revisions

114. By Edward Hope-Morley

Update tempest section examples in README

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: