OpenStack Charm Testing

Merge lp://staging/~hopem/openstack-charm-testing/fix-designate-bundle into lp://staging/openstack-charm-testing

fix-designate-bundle
Merge into trunk

Proposed by Edward Hope-Morley on 2016-11-01

Status:	Merged
Merged at revision:	268
Proposed branch:	lp://staging/~hopem/openstack-charm-testing/fix-designate-bundle
Merge into:	lp://staging/openstack-charm-testing
Diff against target:	166 lines (+73/-21) 1 file modified bundles/dev/designate.yaml (+73/-21)
To merge this branch:	bzr merge lp://staging/~hopem/openstack-charm-testing/fix-designate-bundle
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Ryan Beisner		2016-11-01	Approve on 2017-02-02
Review via email: mp+309767@code.staging.launchpad.net

Revision history for this message

Billy Olsen (billy-olsen) wrote on 2016-11-01:

With this being in the dev bundles, should't the branch be from the designate git branches rather than cs:designate/cs:designate-bind. I think we should roll those in so we have stable branches as well, but with this change we're mixing stable/dev.

Revision history for this message

Edward Hope-Morley (hopem) wrote on 2016-11-10:

As far as I know you can't deploy from git with reactive charms but instead we can deploy from cs:~openstack-charmers-next

lp://staging/~hopem/openstack-charm-testing/fix-designate-bundle updated on 2016-11-10

256. By Edward Hope-Morley on 2016-11-10: use ~openstack-charmers-next

Revision history for this message

Ryan Beisner (1chb1n) wrote on 2017-02-01:

Thank you for your work on this. Apologies for the delay in review. Please see in-line comments re: openstack-services-legacy being unused, and Wily being EOL.

review: Needs Fixing

Revision history for this message

Ryan Beisner (1chb1n) wrote on 2017-02-02:

Actually, will merge then fix up the couple of items raised as a trivial followup. Thanks for your work on this!

review: Approve