maas-deployer

Merge lp://staging/~hopem/maas-deployer/lp1478789 into lp://staging/~maas-deployers/maas-deployer/next

  1. lp1478789
  2. Merge into next
Proposed by Edward Hope-Morley
Status: Merged
Merged at revision: 20
Proposed branch: lp://staging/~hopem/maas-deployer/lp1478789
Merge into: lp://staging/~maas-deployers/maas-deployer/next
Diff against target: 338 lines (+195/-76)
7 files modified
maas_deployer/tests/test_engine.py (+78/-0)
maas_deployer/tests/test_utils.py (+3/-7)
maas_deployer/tests/utils.py (+11/-0)
maas_deployer/vmaas/engine.py (+93/-65)
requirements.txt (+5/-0)
test-requirements.txt (+3/-0)
tox.ini (+2/-4)
To merge this branch: bzr merge lp://staging/~hopem/maas-deployer/lp1478789
Reviewer Review Type Date Requested Status
Felipe Reyes Approve
MAAS Deployers Pending
Review via email: mp+268753@code.staging.launchpad.net

This proposal supersedes a proposal from 2015-08-19.

To post a comment you must log in.
Revision history for this message
Felipe Reyes (freyes) wrote : Posted in a previous version of this proposal

In general this looks good, just a few minor comments inline.

pep8, pylint and unit testing are running fine.
$ tox -e pep8
pep8 create: /tmp/maas-deployer/.tox/pep8
pep8 installdeps: -r/tmp/maas-deployer/test-requirements.txt
pep8 runtests: PYTHONHASHSEED='3988060135'
pep8 runtests: commands[0] | flake8 maas_deployer
______________________________________________________________________________________________________ summary ______________________________________________________________________________________________________
  pep8: commands succeeded
  congratulations :)
$ tox -e py27
py27 create: /tmp/maas-deployer/.tox/py27
py27 installdeps: -r/tmp/maas-deployer/test-requirements.txt
py27 runtests: PYTHONHASHSEED='3617227369'
py27 runtests: commands[0] | nosetests maas_deployer.tests
......
----------------------------------------------------------------------
Ran 6 tests in 0.005s

OK
______________________________________________________________________________________________________ summary ______________________________________________________________________________________________________
  py27: commands succeeded
  congratulations :)

review: Needs Fixing
Revision history for this message
Edward Hope-Morley (hopem) : Posted in a previous version of this proposal
Revision history for this message
Felipe Reyes (freyes) wrote :

LGTM.

  pylint: commands succeeded
  pep8: commands succeeded
  py27: commands succeeded

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches