Merge lp://staging/~hopem/charms/trusty/rabbitmq-server/min-cluster-size into lp://staging/~openstack-charmers-archive/charms/trusty/rabbitmq-server/next

Proposed by Edward Hope-Morley
Status: Merged
Merged at revision: 93
Proposed branch: lp://staging/~hopem/charms/trusty/rabbitmq-server/min-cluster-size
Merge into: lp://staging/~openstack-charmers-archive/charms/trusty/rabbitmq-server/next
Diff against target: 105 lines (+56/-2)
3 files modified
config.yaml (+6/-0)
hooks/rabbitmq_server_relations.py (+33/-2)
unit_tests/test_rabbitmq_server_relations.py (+17/-0)
To merge this branch: bzr merge lp://staging/~hopem/charms/trusty/rabbitmq-server/min-cluster-size
Reviewer Review Type Date Requested Status
Liam Young (community) Approve
Review via email: mp+256686@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Liam Young (gnuoy) wrote :

This won't be needed once the charm has juju leadership election support. However, this will fix current ha deploys so +1 as long as it's been tested.

review: Approve
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #3449 rabbitmq-server-next for hopem mp256686
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/3449/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #3661 rabbitmq-server-next for hopem mp256686
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/3661/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #3450 rabbitmq-server-next for hopem mp256686
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/3450/

Revision history for this message
Liam Young (gnuoy) wrote :

LGTM +1

review: Approve
94. By Edward Hope-Morley

added unit test

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches