Merge lp://staging/~hopem/charm-helpers/lp1694963 into lp://staging/charm-helpers
Proposed by
Edward Hope-Morley
| Status: | Superseded |
|---|---|
| Proposed branch: | lp://staging/~hopem/charm-helpers/lp1694963 |
| Merge into: | lp://staging/charm-helpers |
| Diff against target: |
128 lines (+94/-0) 2 files modified
charmhelpers/contrib/storage/linux/ceph.py (+42/-0) tests/contrib/storage/test_linux_ceph.py (+52/-0) |
| To merge this branch: | bzr merge lp://staging/~hopem/charm-helpers/lp1694963 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Billy Olsen | Approve | ||
| Alex Kavanagh (community) | Needs Fixing | ||
|
Review via email:
|
|||
This proposal has been superseded by a proposal from 2017-06-09.
To post a comment you must log in.
Revision history for this message
| Alex Kavanagh (ajkavanagh) wrote | # |
Unmerged revisions
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I'm not sure I understand the rationale of using another store for this persistent data? why not just use the regular kv() store and just use the same 'namespace' that it already being proposed; it's unlikely to clash with anything else. Plus, the decorator will not be needed, and it simplifies the code.