Ubuntu Repository Cache Charm

Merge lp://staging/~hloeung/ubuntu-repository-cache/metadata-sync-to-peers-less-juju into lp://staging/ubuntu-repository-cache

  1. metadata-sync-to-peers-less-juju
  2. Merge into layer-ubuntu-repository-cache
Proposed by Haw Loeung
Status: Merged
Approved by: Haw Loeung
Approved revision: 386
Merged at revision: 383
Proposed branch: lp://staging/~hloeung/ubuntu-repository-cache/metadata-sync-to-peers-less-juju
Merge into: lp://staging/ubuntu-repository-cache
Diff against target: 414 lines (+142/-83)
10 files modified
hooks/hooks.py (+24/-28)
lib/ubuntu_repository_cache/metadata_cleanup.py (+60/-0)
lib/ubuntu_repository_cache/metadata_sync.py (+1/-1)
lib/ubuntu_repository_cache/mirror.py (+10/-16)
lib/ubuntu_repository_cache/service.py (+33/-29)
templates/cron/ubuntu-repository-cache-config (+2/-1)
templates/cron/ubuntu-repository-cache-cron (+5/-1)
tests/110-multi_unit.simple (+2/-2)
tests/140-failover.simple (+4/-4)
tests/util.py (+1/-1)
To merge this branch: bzr merge lp://staging/~hloeung/ubuntu-repository-cache/metadata-sync-to-peers-less-juju
Reviewer Review Type Date Requested Status
James Simpson Approve
Ubuntu Repository Cache Charmers, Canonical Pending
Review via email: mp+428686@code.staging.launchpad.net

Commit message

Untie metadata sync from relying on Juju

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

lp://staging/~hloeung/ubuntu-repository-cache/metadata-sync-to-peers-less-juju updated
384. By Haw Loeung

Fixed missing newline before EOF causing cron to fail to load our crontab

385. By Haw Loeung

Fixed here too

Revision history for this message
James Simpson (jsimpso) wrote :

LGTM, a couple of comments in-line but nothing worth blocking on!

review: Approve
Revision history for this message
Haw Loeung (hloeung) :
lp://staging/~hloeung/ubuntu-repository-cache/metadata-sync-to-peers-less-juju updated
386. By Haw Loeung

Add missing metric, also rename ubuntu_repository_cache_metadata_sync_total_duration to ubuntu_repository_cache_metadata_sync_duration making it consistent

Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 383

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches