Merge lp://staging/~hloeung/ubuntu-geonames/add-country-continent into lp://staging/ubuntu-geonames
Proposed by
Haw Loeung
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merged at revision: | 33 | ||||
| Proposed branch: | lp://staging/~hloeung/ubuntu-geonames/add-country-continent | ||||
| Merge into: | lp://staging/ubuntu-geonames | ||||
| Diff against target: |
50 lines (+5/-3) 2 files modified
geoname-modpython.py (+3/-1) geoname.py (+2/-2) |
||||
| To merge this branch: | bzr merge lp://staging/~hloeung/ubuntu-geonames/add-country-continent | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Paul Collins | lgtm | Approve | |
| Ubuntu Geonames Hackers | Pending | ||
|
Review via email:
|
|||
Description of the change
We're already importing continent from countryInfo.txt. Let's serve that up.
Per http://
Continent codes :
AF : Africa geonameId=6255146
AS : Asia geonameId=6255147
EU : Europe geonameId=6255148
NA : North America geonameId=6255149
OC : Oceania geonameId=6255151
SA : South America geonameId=6255150
AN : Antarctica geonameId=6255152
To post a comment you must log in.
Revision history for this message
| Paul Collins (pjdc) | # |
review:
Approve
(lgtm)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
