Merge lp://staging/~hjd/apport/openjdk-9-bugpattern into lp://staging/~ubuntu-bugcontrol/apport/ubuntu-bugpatterns

Proposed by Hans Joachim Desserud
Status: Merged
Merged at revision: 564
Proposed branch: lp://staging/~hjd/apport/openjdk-9-bugpattern
Merge into: lp://staging/~ubuntu-bugcontrol/apport/ubuntu-bugpatterns
Diff against target: 13 lines (+5/-0)
1 file modified
bugpatterns.xml (+5/-0)
To merge this branch: bzr merge lp://staging/~hjd/apport/openjdk-9-bugpattern
Reviewer Review Type Date Requested Status
Brian Murray Needs Fixing
Review via email: mp+309378@code.staging.launchpad.net

Description of the change

Inspired by Brian Murray's post to ubuntu-bugsquad [1], I've created a pattern for bug 1550950. :)

Tested a bit and found that the pattern matches both this the original bug as well as all but three of the duplicates. (The non-matches either lack DpkgTerminalLog or doesn't contain the error message for unknown reasons) I haven't done any testing to see what isn't covered, but I tried to make the pattern rather specific to avoid catching unrelated issues.

Let me know what you think.

[1] https://lists.ubuntu.com/archives/ubuntu-bugsquad/2016-September/005038.html

To post a comment you must log in.
Revision history for this message
Brian Murray (brian-murray) wrote :

Thanks for working on this!

This looks good, but I think it should be more specific, we don't hide this issue if it comes up again by stopping reporting of this crash. (This would happen because apport uses bug patterns to redirect people to a bug.)

I used lp-bug-dupe-properties to see if we could specify the package version.

 $ lp-bug-dupe-properties -D Package -b 1550950
LP: #1550950 has 72 duplicates
  None: 1593191 1618825
  openjdk-9-jdk (not installed): 1559689 1565270 1570768 1571435 1571659 1572185 1572797 1573406 1573745 1573913 1574126 1574386 1575525 1575615 1575827 1576456 1577363 1577564 1577671 1579474 1579791 1580269 1580662 1581776 1582420 1582834 1586609 1586723 1588578 1589729 1592437 1593062 1593501 1595251 1595434 1595961 1596280 1598419 1599107 1599415 1600269 1603598 1603644 1605025 1607090 1608352 1608408 1608976 1610453 1610635 1610699 1611189 1612889 1613371 1615372 1615877 1615975 1617378 1619551 1621250 1621913 1622592 1622598 1622723 1622724 1628665 1630712 1631844
  openjdk-9-jdk 9~b114-0ubuntu1: 1591768
  openjdk-9-jdk-headless 9~b114-0ubuntu1: 1615119

That won't work because the package is being installed. What else could we use?

review: Needs Fixing
Revision history for this message
Brian Murray (brian-murray) wrote :

The package version we are installing appears in the DpkgTerminalLog so let's add that too.

Revision history for this message
Brian Murray (brian-murray) wrote :

I've added this bit.

<re key="DpkgTerminalLog">openjdk-9-(jdk|jdk-headless):.* \(9~(b107-0ubuntu1|b112-2|b114-0ubuntu1)\)</re>

Revision history for this message
Hans Joachim Desserud (hjd) wrote :

>The package version we are installing appears in the DpkgTerminalLog so let's add that too.

Nice. I tried to find a way to restrict it since it is fixed in later releases, but didn't think about this.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.