Merge into trunk : unity-control-center.bug-warning-fixes : Code : Unity Control Center

Merge lp://staging/~hikiko/unity-control-center/unity-control-center.bug-warning-fixes into lp://staging/unity-control-center

Proposed by Eleni Maria Stea
Status: Rejected
Rejected by: Sebastien Bacher
Proposed branch: lp://staging/~hikiko/unity-control-center/unity-control-center.bug-warning-fixes
Merge into: lp://staging/unity-control-center
Diff against target: 46 lines (+5/-4)
1 file modified
To merge this branch: bzr merge lp://staging/~hikiko/unity-control-center/unity-control-center.bug-warning-fixes
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
desrt (community) Needs Fixing
Sebastien Bacher Pending
Unity Control Center development team Pending
Review via email: mp+208162@code.staging.launchpad.net

Commit message

Small fixes:
Replaced malloc with g_new to avoid leaks and removed the \n from g_warnings

Description of the change

Small fixes:
Replaced malloc with g_new to avoid leaks and removed the \n from g_warnings

To post a comment you must log in.
Revision history for this message
desrt (desrt) wrote :

you need to call g_free() on that value that you g_new()'d...

review: Needs Fixing
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Sebastien Bacher (seb128) wrote :

@Eleni: do you consider the changes ready for review? if so please change the status to "needs review". Did you also plan to simplify the gvariant use in that merge request or in a following one?

Revision history for this message
Eleni Maria Stea (hikiko) wrote :

Actually, I plan to submit another MP where I'll replace GVariant arrays with GVariantBuilder soon. But let's merge this one first :)

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Eleni Maria Stea (hikiko) wrote :

https://code.launchpad.net/~hikiko/unity-control-center/unity-control-center.replaced-gvariant-array-with-gvariant-builder/+merge/208313 Here's the other MP, where I use the GVariantBuilder (thanks Ryan for the suggestion) so if you agree, I could delete (or reject) this one?

Revision history for this message
Sebastien Bacher (seb128) wrote :

sure, let's do that (you still have a g_warning \n to fix in the other one though)

Revision history for this message
Eleni Maria Stea (hikiko) wrote :

yes, I started from trunk :D let me fix it...

Unmerged revisions

12736. By Eleni Maria Stea

g_free

12735. By Eleni Maria Stea

replaced malloc with g_new to avoid leaks

12734. By Eleni Maria Stea

removed \n from g_warnings

Preview Diff

Failed to fetch available diffs.

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches