Merge lp://staging/~hikiko/unity-control-center/u-c-c.checkbox-for-app-scaling into lp://staging/unity-control-center

The checkbox is the quick solution to have the feature ready before the Ubuntu release. I've started implementing this design: https://wiki.ubuntu.com/BrightnessAndDisplays#Displays

PASSED: Continuous integration, rev:12759
http://jenkins.qa.ubuntu.com/job/unity-control-center-ci/80/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-control-center-trusty-amd64-ci/80
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-control-center-trusty-armhf-ci/80
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-control-center-trusty-i386-ci/81

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-control-center-ci/80/rebuild

Thanks for the work, as discussed on IRC the logic seems too complex there. We need at least a ffe/uife bug with explanations of what the code tries to achieve.

If we don't go for the full design I would only add a checkbox that toggle the gsettings keys, the by monitor smartness seems confusing rather than useful...

Thank you Seb,
Here's the description of the initial problem and the solution:
https://bugs.launchpad.net/unity-control-center/+bug/1294578

This is just a partial solution, because we promised to add a checkbox in 14.04 at UDS. We ll certainly rewrite this feature and further discuss it with the designers for the next release.

86 + if (!(selected_monitor_name = malloc (sizeof *monitor_name)))
87 + return;
88 +
89 + strcpy (selected_monitor_name, monitor_name);

sizeof doesn't return the size of the string, but the size of the type you're passing to it (in this case 1). Also, it's missing space for the terminating \0 and there's no need to check the return value of malloc for NULL. I suggest just using

  selected_monitor_name = g_strdup(monitor_name);

selected_monitor_name is never freed (also not the one from line 186 in the diff)

Sorry Laney, that piece of code wasnt necessary at all, I ve deleted it... I had to finish the branch very quickly yesterday and didn't notice I forgot the malloc and the string operations, it's fixed now, thanks for pointing it now :)

setting as rejected, the UI was tweaked differently