Nux

Merge lp://staging/~hikiko/nux/nux.virt-destructors into lp://staging/nux

  1. nux.virt-destructors
  2. Merge into trunk
Proposed by Eleni Maria Stea
Status: Merged
Approved by: Brandon Schaefer
Approved revision: 827
Merged at revision: 827
Proposed branch: lp://staging/~hikiko/nux/nux.virt-destructors
Merge into: lp://staging/nux
Diff against target: 65 lines (+6/-2)
4 files modified
NuxCore/AnimationController.h (+2/-2)
NuxCore/Property.h (+1/-0)
NuxGraphics/GLResourceManager.h (+1/-0)
tests/gtest-nux-gesturebroker.cpp (+2/-0)
To merge this branch: bzr merge lp://staging/~hikiko/nux/nux.virt-destructors
Reviewer Review Type Date Requested Status
Brandon Schaefer (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+193926@code.staging.launchpad.net

Commit message

added virtual destructors where missing (fixing static analysis errors)

Description of the change

added virtual destructors where missing (fixing static analysis errors)

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:827
http://jenkins.qa.ubuntu.com/job/nux-ci/91/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/nux-trusty-amd64-ci/13
    SUCCESS: http://jenkins.qa.ubuntu.com/job/nux-trusty-armhf-ci/13
    SUCCESS: http://jenkins.qa.ubuntu.com/job/nux-trusty-i386-ci/13

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/nux-ci/91/rebuild

review: Approve (continuous-integration)
Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

LGTM

review: Approve
Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

Actually this break the ABI for nux, but i also heard this was talked about...so for now just moving to needs fixing :)

review: Needs Fixing
Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

Merging this first, then nux perf branch which will handle the ABI break

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches