Compiz

Merge lp://staging/~hikiko/compiz/compiz.tdwindows-condition-modified into lp://staging/compiz/0.9.12

  1. compiz.tdwindows-condition-modified
  2. Merge into 0.9.12
Proposed by Eleni Maria Stea
Status: Merged
Approved by: Stephen M. Webb
Approved revision: 3970
Merged at revision: 3965
Proposed branch: lp://staging/~hikiko/compiz/compiz.tdwindows-condition-modified
Merge into: lp://staging/compiz/0.9.12
Prerequisite: lp://staging/~hikiko/compiz/compiz.use-pipeline-with-3d-clipping
Diff against target: 12 lines (+1/-1)
1 file modified
plugins/td/src/3d.cpp (+1/-1)
To merge this branch: bzr merge lp://staging/~hikiko/compiz/compiz.tdwindows-condition-modified
Reviewer Review Type Date Requested Status
Stephen M. Webb Approve
PS Jenkins bot (community) continuous-integration Approve
Unity Team Pending
Review via email: mp+266997@code.staging.launchpad.net

Commit message

Sometimes the MultipleCubes, Automatic or OneBigCube option might be set although we are not in multimonitor. Modified the 3d windows plugin to check the number of monitors as well.

Description of the change

Sometimes the MultipleCubes, Automatic or OneBigCube option might be set although we are not in multimonitor. Modified the 3d windows plugin to check the number of monitors as well.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:3970
http://jenkins.qa.ubuntu.com/job/compiz-ci/76/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/compiz-wily-amd64-ci/21
    SUCCESS: http://jenkins.qa.ubuntu.com/job/compiz-wily-armhf-ci/21
    SUCCESS: http://jenkins.qa.ubuntu.com/job/compiz-wily-i386-ci/21

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/compiz-ci/76/rebuild

review: Approve (continuous-integration)
Revision history for this message
Stephen M. Webb (bregma) :
review: Approve
Revision history for this message
Doug McMahon (mc3man) wrote :

Was this tested with cube/rotate?, ie.
Enable cube/rotate, set to 4x1 workspaces
Enable td plugin
log out/in
open a window on ws1, rotate to ws2, rotate back to ws1
Here the window on ws1 is not immediately visible, gets redrawn which causes a flash effect
(intel gpu, desktop-based viewport switching ('scroll on desktop') enabled
If not duplicable then likely local issue here as this compiz is not yet been released (in proposed..

Revision history for this message
Eleni Maria Stea (hikiko) wrote :

Thank you for reporting this!

I didn't manage to reproduce the problem you described and I suspect 2 reasons for that:

1- you didn't load the plugins properly (this should be fixed by restarting compiz) and that's why you get the issue

2- you have different plugins than me enabled and it's not the cube/rotate that causes the problem but something else.

Could you please tell us all the compiz plugins you have enabled when this problem occurs so that I have the same environment? (You can find them in ccsm)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches