Compiz

Merge lp://staging/~hikiko/compiz/compiz.shared-transform-ezoom into lp://staging/compiz/0.9.12

  1. compiz.shared-transform-ezoom
  2. Merge into 0.9.12
Proposed by Eleni Maria Stea
Status: Needs review
Proposed branch: lp://staging/~hikiko/compiz/compiz.shared-transform-ezoom
Merge into: lp://staging/compiz/0.9.12
Prerequisite: lp://staging/~hikiko/compiz/compiz.use-pipeline-with-3d-clipping
Diff against target: 32 lines (+6/-0)
2 files modified
plugins/ezoom/src/ezoom.cpp (+4/-0)
plugins/opengl/include/opengl/opengl.h (+2/-0)
To merge this branch: bzr merge lp://staging/~hikiko/compiz/compiz.shared-transform-ezoom
Reviewer Review Type Date Requested Status
Sam Spilsbury Needs Fixing
PS Jenkins bot (community) continuous-integration Needs Fixing
Marco Trevisan (Treviño) Pending
Unity Team Pending
Review via email: mp+266357@code.staging.launchpad.net

This proposal supersedes a proposal from 2015-07-03.

Commit message

saves the enhanced zoom transformation on gScreen so that other plugins that use the opengl can use it

Description of the change

saves the enhanced zoom transformation on gScreen so that other plugins that use the opengl can use it

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

PASSED: Continuous integration, rev:3950
http://jenkins.qa.ubuntu.com/job/compiz-ci/62/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/compiz-wily-amd64-ci/7
    SUCCESS: http://jenkins.qa.ubuntu.com/job/compiz-wily-armhf-ci/7
    SUCCESS: http://jenkins.qa.ubuntu.com/job/compiz-wily-i386-ci/7

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/compiz-ci/62/rebuild

review: Approve (continuous-integration)
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote : Posted in a previous version of this proposal

vertexbuffer and 3d changes are probably for another MP

Revision history for this message
Eleni Maria Stea (hikiko) wrote : Posted in a previous version of this proposal

> vertexbuffer and 3d changes are probably for another MP

Right. Basically that's part of the 3d windows plugin fix, which I forgot to add as a prerequisite branch :) Apologies!

lp://staging/~hikiko/compiz/compiz.shared-transform-ezoom updated
3951. By Eleni Maria Stea

removed comment

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:3950
http://jenkins.qa.ubuntu.com/job/compiz-ci/71/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/compiz-wily-amd64-ci/16/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/compiz-wily-armhf-ci/16/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/compiz-wily-i386-ci/16/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/compiz-ci/71/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:3951
http://jenkins.qa.ubuntu.com/job/compiz-ci/72/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/compiz-wily-amd64-ci/17/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/compiz-wily-armhf-ci/17/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/compiz-wily-i386-ci/17/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/compiz-ci/72/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Sam Spilsbury (smspillaz) wrote :

I don't really understand this - if Unity needs to use the transform, it is available to it in glPaintOutput.

I also note the age of this branch - is it still relevant or can it be dropped?

review: Needs Fixing
Reply

Unmerged revisions

3951. By Eleni Maria Stea

removed comment

3950. By Eleni Maria Stea

renamed sh_transform to ezoom_transform

3949. By Eleni Maria Stea

added sh_transform member to gScreen to store transformations that
need to be exchanged between plugins (eg ezoom and unityshell), filled it
in ezoom

3948. By Eleni Maria Stea

local merge

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches