Compiz

Merge lp://staging/~hikiko/compiz/compiz.fix-811591 into lp://staging/compiz/0.9.12

  1. compiz.fix-811591
  2. Merge into 0.9.12
Proposed by Eleni Maria Stea
Status: Work in progress
Proposed branch: lp://staging/~hikiko/compiz/compiz.fix-811591
Merge into: lp://staging/compiz/0.9.12
Diff against target: 23 lines (+0/-10)
1 file modified
plugins/put/src/put.cpp (+0/-10)
To merge this branch: bzr merge lp://staging/~hikiko/compiz/compiz.fix-811591
Reviewer Review Type Date Requested Status
Andrea Azzarone Needs Fixing
PS Jenkins bot (community) continuous-integration Needs Fixing
Marco Trevisan (Treviño) Pending
Unity Team Pending
Review via email: mp+272359@code.staging.launchpad.net

Commit message

Fix for put plugin.

Description of the change

Fix for put plugin.

To post a comment you must log in.
lp://staging/~hikiko/compiz/compiz.fix-811591 updated
3979. By Eleni Maria Stea

removed comment

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:3978
http://jenkins.qa.ubuntu.com/job/compiz-ci/87/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/compiz-wily-amd64-ci/32/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/compiz-wily-armhf-ci/32/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/compiz-wily-i386-ci/32/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/compiz-ci/87/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:3979
http://jenkins.qa.ubuntu.com/job/compiz-ci/88/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/compiz-wily-amd64-ci/33/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/compiz-wily-armhf-ci/33/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/compiz-wily-i386-ci/33/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/compiz-ci/88/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Andrea Azzarone (azzar1) wrote :

It works now but the two comments are now invalid
/* take the shortest horizontal path to the destination viewport */

and the other one as well:
/* we need to do this for the vertical destination viewport too */

Right?

review: Needs Fixing
Reply
Revision history for this message
Andrea Azzarone (azzar1) wrote :

Ops actually the problem is still there. I'm using multimunitor with 9 workspaces sending a termianl window from 1 to 8.

review: Needs Fixing
Reply
Revision history for this message
Eleni Maria Stea (hikiko) wrote :

I forgot to test in multimonitor :/ In progress...

Reply
lp://staging/~hikiko/compiz/compiz.fix-811591 updated
3980. By Eleni Maria Stea

removed irrelevant comments

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

No worries, I think you can keep this in hold, since put plugin is not relevant for unity.

Reply
Revision history for this message
Eleni Maria Stea (hikiko) wrote :

+1

Reply

Unmerged revisions

3980. By Eleni Maria Stea

removed irrelevant comments

3979. By Eleni Maria Stea

removed comment

3978. By Eleni Maria Stea

fixes bug: #811591 solution proposed by Sam Spilsbury here:
https://bugs.launchpad.net/compiz/+bug/811591

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches