Juju Charms Collection
glance package

Merge lp://staging/~heut2008/charms/trusty/glance/config-flags into lp://staging/~openstack-charmers-archive/charms/trusty/glance/next

Proposed by Yaguang Tang on 2014-07-31

Status:	Rejected
Rejected by:	James Page on 2016-02-18
Proposed branch:	lp://staging/~heut2008/charms/trusty/glance/config-flags
Merge into:	lp://staging/~openstack-charmers-archive/charms/trusty/glance/next
Diff against target:	123 lines (+53/-2) 5 files modified config.yaml (+12/-0) hooks/glance_contexts.py (+24/-0) hooks/glance_utils.py (+5/-2) templates/icehouse/glance-api.conf (+6/-0) templates/icehouse/glance-registry.conf (+6/-0)
To merge this branch:	bzr merge lp://staging/~heut2008/charms/trusty/glance/config-flags
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
Edward Hope-Morley		Needs Fixing on 2014-10-06
James Page	2014-07-31	Needs Fixing on 2014-08-11
Review via email: mp+228992@code.staging.launchpad.net

This proposal supersedes a proposal from 2014-07-31.

Revision history for this message

James Page (james-page) on 2014-08-11:

review: Needs Fixing

Revision history for this message

James Page (james-page) on 2014-08-11:

review: Needs Fixing

Revision history for this message

Yaguang Tang (heut2008) wrote on 2014-08-27:

Fixed, please review.

Revision history for this message

Edward Hope-Morley (hopem) wrote on 2014-09-12:

Please see inline comment.

review: Needs Fixing

lp://staging/~heut2008/charms/trusty/glance/config-flags updated on 2014-09-18

58. By Yaguang Tang on 2014-09-18: Support setting user defined options for glance-api and
glance-registry services

Revision history for this message

Edward Hope-Morley (hopem) wrote on 2014-09-23:

Lint errors:

$ make lint
Running flake8 tests:
hooks/glance_contexts.py:100:41: F821 undefined name 'registry_flags'
hooks/glance_contexts.py:103:25: F821 undefined name 'config_flags_parser'
hooks/glance_contexts.py:104:13: F841 local variable 'registry_flags' is assigned to but never used
hooks/glance_contexts.py:104:30: F821 undefined name 'config_flags_parser'
make: *** [lint] Error 1

@yaguang make sure run 'make lint' and ensure there are no errors before you submit. Also see inline comment.

review: Needs Fixing

lp://staging/~heut2008/charms/trusty/glance/config-flags updated on 2014-09-25

59. By Yaguang Tang on 2014-09-25: Fix mix naming errors

Revision history for this message

Edward Hope-Morley (hopem) wrote on 2014-10-06:

Yaguang, i think we could improve this by extending the charm-helpers context to support alternate flags - see my inline comment below for an example of how this could be done. This way we do not have to carry a custome version in the this charm and if other charm ever need this functionilty it is is available to them.

review: Needs Fixing

Unmerged revisions

59. By Yaguang Tang on 2014-09-25: Fix mix naming errors
58. By Yaguang Tang on 2014-09-18: Support setting user defined options for glance-api and
glance-registry services
57. By Yaguang Tang on 2014-08-25: Remove default key for config flags
56. By Yaguang Tang on 2014-07-31: Support config-flags to glance api.