Tools used by the Ubuntu QA Team

Merge lp://staging/~hernejj/ubuntu-qa-tools/better_hugday into lp://staging/ubuntu-qa-tools

  1. better_hugday
  2. Merge into master
Proposed by Jason J. Herne
Status: Needs review
Proposed branch: lp://staging/~hernejj/ubuntu-qa-tools/better_hugday
Merge into: lp://staging/ubuntu-qa-tools
Diff against target: 1040 lines (+834/-56)
11 files modified
README (+19/-6)
debian/changelog (+11/-0)
hugday-tools/hugday (+113/-49)
hugday_lib/cookie_lib/ChromeCookieLoader.py (+63/-0)
hugday_lib/cookie_lib/CookieFinder.py (+149/-0)
hugday_lib/cookie_lib/CookieLoader.py (+209/-0)
hugday_lib/cookie_lib/EpiphanyCookieLoader.py (+53/-0)
hugday_lib/cookie_lib/FirefoxCookieLoader.py (+60/-0)
hugday_lib/cookie_lib/KonquerorCookieLoader.py (+111/-0)
hugday_lib/cookie_lib/SeamonkeyCookieLoader.py (+43/-0)
setup.py (+3/-1)
To merge this branch: bzr merge lp://staging/~hernejj/ubuntu-qa-tools/better_hugday
Reviewer Review Type Date Requested Status
Markus Korn Pending
Ubuntu Bug Control Pending
Review via email: mp+23257@code.staging.launchpad.net

Commit message

Adds code to do the following:
- Supported browsers: Firefox, Epiphany, Seamonkey, Google Chrome, Konqueror
- Automatic cookie detection for all supported browsers.
- User no longer has to close the browser to find cookies.
- Cookie file format automatically detected when --cookie is given
- User can specify a browser (--browser) and cookie is automatically found within that browser's cookie files.
- Some simple code cleanup and extra commenting in hugday tool.

Description of the change

I've been working on some improvements to the hugday tool (part of the ubuntu-qa-tools) that should make hugday easier to use. Making hugday easier to use will lower the "barrier of entry" for new comers who are interested in participating in the Ubuntu Bug Days. And anything we can do to help people help Ubuntu is a good idea in my book ;).

I've added code to allow for more robust cookie handling by the "hugday init" sub-command. Here is a list of features currently implemented in my branch:
- Supported browsers: Firefox, Epiphany, Seamonkey, Google Chrome, Konqueror
- Automatic cookie detection for all supported browsers.
- User no longer has to close the browser to find cookies.
- Cookie file format automatically detected when --cookie is given
- User can specify a browser (--browser) and cookie is automatically found within that browser's cookie files.
- Some simple code cleanup and extra commenting in hugday tool.

If this is something that bug-control is interested in I'd be happy to have these features merged back into the official ubuntu-qa-tools-branch. Although I must admit I'm not sure what the process is for officially requesting such a merge.

To post a comment you must log in.
Revision history for this message
Brian Murray (brian-murray) wrote :

This sounds really exciting! You have followed the proper process for requesting such a merge but unfortunately I don't think we can get this into Lucid since we are past feature freeze. I'm requesting that the original author look at your changes too.

Reply
Revision history for this message
Jason J. Herne (hernejj) wrote :

> This sounds really exciting! You have followed the proper process for
> requesting such a merge but unfortunately I don't think we can get this into
> Lucid since we are past feature freeze. I'm requesting that the original
> author look at your changes too.

Hi Brian. Thanks for your interest. It's not problem for me if this has to wait for Maverick Meerkat.. I understand how the schedule works :). Once code review is complete I can always put an updated package in my PPA. Then others can test the changes if they are interested.

Reply
lp://staging/~hernejj/ubuntu-qa-tools/better_hugday updated
339. By Jason J. Herne

- Added Google Chromium support

Revision history for this message
Jason J. Herne (hernejj) wrote :

One note I'd like to make for the reviewers.

The hugday code that I replaced was searching for two cookies: MOIN_SESSION and MOIN_ID. My new code only looks for MOIN_SESSION. I'm not sure what MOIN_ID is or where it comes from but I could not find any instances of it in my testing.

If there is a valid reason to continue to search for MOIN_ID as well as MOIN_SESSION then please let me know and I'll modify this branch to look for MOIN_ID if MOIN_SESSION is not found.

Reply
Revision history for this message
Jason J. Herne (hernejj) wrote :

Just a friendly poke to find out what the status is on this review. :)

Reply
Revision history for this message
Markus Korn (thekorn) wrote :

Hey Jason,
I'm sorry, I totally forgot about this merge proposal. Reviewing this huge diff will take some time, but I hope to get it done until next weekend.

Just a side note, have you ever thought about moving your cookielib into a separate project/package? Because it seems to be useful for other python scripts too, and as a side effect it would reduce the size of this diff.

Sorry again,
and thanks for the reminder,
have a nice day,
Markus

Reply
Revision history for this message
Jason J. Herne (hernejj) wrote :

On Mon, Aug 2, 2010 at 5:14 PM, Markus Korn <email address hidden> wrote:

> Hey Jason,
> I'm sorry, I totally forgot about this merge proposal. Reviewing this huge
> diff will take some time, but I hope to get it done until next weekend.
>
> Just a side note, have you ever thought about moving your cookielib into a
> separate project/package? Because it seems to be useful for other python
> scripts too, and as a side effect it would reduce the size of this diff.
>
> Sorry again,
> and thanks for the reminder,
> have a nice day,
> Markus
> --
>
> https://code.launchpad.net/~hernejj/ubuntu-qa-tools/better_hugday/+merge/23257<https://code.launchpad.net/%7Ehernejj/ubuntu-qa-tools/better_hugday/+merge/23257>
> You are the owner of lp:~hernejj/ubuntu-qa-tools/better_hugday.
>

I had considered separating out the cookielib code but I'm not sure what
other use it has at the moment. Seems preemptive to do it without another
project that can use it.
It can always be done as follow on work when another need arises. It would
not be that hard to do.

--
- Jason J. Herne (<email address hidden>)

Reply

Unmerged revisions

339. By Jason J. Herne

- Added Google Chromium support

338. By Jason J. Herne

- Fixed errors in usage information for hugday
- Added previously forgotten cookie loader file
- Updated readme and changelog

337. By Jason J. Herne

- ChromeCookieLoader.py: Fixed bug, need to check that cookies were loaded BEFORE we iterate through them ;)
- CookieFinder.py: Added missing import of os module
- CookieFinder.py: Added Konqueror support
- CookieFinder.py: Change browser string comparison to always use lower case
- CookieFinder.py: Fixed bug, In get_cookeies(), don't return if a cookie loader has no cookies, need to check ALL cookie loaders.
- KonquerorCookieLoader.py: Initial import.

336. By Jason J. Herne

- User can now specify exactly which browser to pull cookie file from: --browser=<firefox|seamonkey|chrome|epiphany>

335. By Jason J. Herne

- bug fix: Expand ~ in path names given by user
- Fixed error mesasge text
- Added print stmt to output the CookieLoader we're using

334. By jason <jason@foobarbaz>

- Fixed timestamp handling in Chrome

333. By jason <jason@foobarbaz>

- Removed unneeded comment from SeamonkeyLoader

332. By Jason J. Herne

- Properly close connection to sqlite database files

331. By Jason J. Herne

- Rewrote existing get_credentials code to use CookieFinder when the user specifies a cookie file on the command line.

330. By Jason J. Herne

- Bug fix: Check that path exists in cookier_scanner routine before scanning it.
- Bug fix: Uncomment exception handling code (originally commented for testing purposes.)
- Cookie Finder/Loader now provides a method to detect if cookie files were loaded.
- All cookie loaders have been updated to support the above method.
- hugday now uses the above method to give a proper error message if no cookie files were found.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.