Storm

Merge lp://staging/~henninge/storm/bug-698344-row-constructor into lp://staging/storm

bug-698344-row-constructor
Merge into trunk

Proposed by Henning Eggers on 2011-01-06

Status:

Merged

Merged at revision:

407

Proposed branch:

lp://staging/~henninge/storm/bug-698344-row-constructor

Merge into:

lp://staging/storm

Diff against target:

31 lines (+10/-0)

2 files modified

storm/expr.py (+5/-0)
tests/expr.py (+5/-0)

To merge this branch:

bzr merge lp://staging/~henninge/storm/bug-698344-row-constructor

Undecided

Fix Released

Link a bug report

Reviewer	Date Requested	Status
Gavin Panella	2011-09-14	Approve on 2011-09-14
Jamu Kakar (community)	2011-01-06	Approve on 2011-09-14
Review via email: mp+45465@code.staging.launchpad.net

Description of the change

This branch adds a Row constructor as a NamedFunc. I admit, I did a lot of copying, like the test and also the __slots__=() line. But I think this is simple enough to "just work". ;-)

Revision history for this message

Jamu Kakar (jkakar) wrote on 2011-09-14:

Looks good to me, +1!

review: Approve

Revision history for this message

Gavin Panella (allenap) wrote on 2011-09-14:

I'm now in ~storm so I can vote on this, but no one has officially inducted me into the Hall of Reviewers. Perhaps there is no such thing... perhaps its first rule is that there is no Hall of Reviewers... still, +1 from me.

review: Approve

lp://staging/~henninge/storm/bug-698344-row-constructor updated on 2011-09-14