Launchpad itself

Merge lp://staging/~henninge/launchpad/bug-591731-is-published-removal into lp://staging/~launchpad/launchpad/recife

  1. bug-591731-is-published-removal
  2. Merge into recife
Proposed by Henning Eggers
Status: Merged
Approved by: Jeroen T. Vermeulen
Approved revision: no longer in the source branch.
Merged at revision: 9137
Proposed branch: lp://staging/~henninge/launchpad/bug-591731-is-published-removal
Merge into: lp://staging/~launchpad/launchpad/recife
Diff against target: 287 lines (+52/-51)
5 files modified
lib/lp/translations/interfaces/potmsgset.py (+2/-2)
lib/lp/translations/model/potmsgset.py (+5/-4)
lib/lp/translations/model/translationimportqueue.py (+1/-1)
lib/lp/translations/tests/test_pofile.py (+34/-34)
lib/lp/translations/tests/test_potmsgset.py (+10/-10)
To merge this branch: bzr merge lp://staging/~henninge/launchpad/bug-591731-is-published-removal
Reviewer Review Type Date Requested Status
Jeroen T. Vermeulen (community) code Approve
Review via email: mp+27166@code.staging.launchpad.net

Commit message

Replaced all occurrences of is_imported, is_current and is_published with their modern counterparts.

Description of the change

Replaced all occurrences of is_imported, is_current and is_published with their modern counterparts. Also fixed a test and formatting while driving by.

To post a comment you must log in.
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Looks good. One change discussed on IRC: instead of a variable called diverged_and_not_current_upstream, it may be easier to read to have one called diverged and another called current_upstream.

Thanks for the drive-by cleanups.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches