Merge lp://staging/~hennekn/ubuntu/trusty/ibus/bug-1240198 into lp://staging/ubuntu/trusty/ibus

Proposed by Hendrik Schrieber
Status: Work in progress
Proposed branch: lp://staging/~hennekn/ubuntu/trusty/ibus/bug-1240198
Merge into: lp://staging/ubuntu/trusty/ibus
Diff against target: 48 lines (+15/-0)
4 files modified
.pc/applied-patches (+1/-0)
debian/changelog (+6/-0)
debian/patches/04_enable_system_layout.patch (+7/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp://staging/~hennekn/ubuntu/trusty/ibus/bug-1240198
Reviewer Review Type Date Requested Status
Aron Xu (community) Needs Fixing
Ubuntu branches Pending
Review via email: mp+220843@code.staging.launchpad.net

Description of the change

This patch is supposed to fix Bug#1240198 by adding an additional config file to set the default value of "use-system-keyboard-layout" to "true" and therefore prevent ibus from falling back to the en-us keyboard layout.

For the setting to take effect "dconf update" has to be run but based on other patches to IBus I suppose this happens automatically via triggers on install.

This is not easily testable since the bug is semi-random and ibus not working as a standalone app. Therefore it should be tested by a wider audience.

This is my first patch and I am not certain if this will work so any guidance or help would be appreciated.

To post a comment you must log in.
Revision history for this message
William Hua (attente) wrote :

Hi, I haven't been able to replicate the original bug, but looking at the diff, I think you need to add 04_enable_system_layout.patch to EXTRA_DIST in data/dconf/Makefile.am.

Revision history for this message
Aron Xu (happyaron) wrote :

Agree with William, and also please clean up those .pc noise. Thanks!

review: Needs Fixing
Revision history for this message
Sebastien Bacher (seb128) wrote :

Changing to "work in progress" so it's out of the sponsoring queue until the pointed issues are resolved, change back to "needs review" then

Unmerged revisions

49. By Hendrik Knackstedt <hendrik@hendrik-Aspire-5750G>

Add patch to fix Bug #1240198 by adding a custom config to enable
the use of the system's keyboard layout by default.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches