Merge lp://staging/~helipad-team/helipad/jenkins_coverage_pull_fix into lp://staging/~helipad-team/helipad/coverage
Proposed by
Chris Gagnon
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://staging/~helipad-team/helipad/jenkins_coverage_pull_fix |
| Merge into: | lp://staging/~helipad-team/helipad/coverage |
| Diff against target: |
537 lines (+441/-31) 5 files modified
gaps/tests.py (+0/-16) gaps/tests/__init__.py (+82/-0) gaps/tests/data/coverage.xml (+328/-0) gaps/util/add.py (+6/-3) gaps/util/jenkins_pull.py (+25/-12) |
| To merge this branch: | bzr merge lp://staging/~helipad-team/helipad/jenkins_coverage_pull_fix |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Allan LeSage | Needs Fixing | ||
|
Review via email:
|
|||
Commit message
fix jenkins pull coverage
To post a comment you must log in.
Unmerged revisions
- 781. By Chris Gagnon
-
add tests fix pep8 issues in jenkins_pull and add.py
- 780. By Chris Gagnon
-
move success condition outside _get_artifact_urls function
- 779. By Chris Gagnon
-
fix jenkins pull
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I think it's ok for _get_artifact_urls to return an empty list.
Either enforce the 'SUCCESS' condition outside this _get_artifact_urls function or make it clear in the docstring that you won't return results for other builds.
This needs a test obviously :) , we can either do now or save for a testing-charette this week IMO.