DockManager

Merge lp://staging/~hel-sheep/dockmanager/mpd into lp://staging/dockmanager

  1. mpd
  2. Merge into trunk
Proposed by Felipe Morales
Status: Merged
Merged at revision: 34
Proposed branch: lp://staging/~hel-sheep/dockmanager/mpd
Merge into: lp://staging/dockmanager
Diff against target: 239 lines (+208/-0)
4 files modified
metadata/Makefile.am (+1/-0)
metadata/mpd_control.py.info (+5/-0)
scripts/Makefile.am (+1/-0)
scripts/mpd_control.py (+201/-0)
To merge this branch: bzr merge lp://staging/~hel-sheep/dockmanager/mpd
Reviewer Review Type Date Requested Status
Rico Tzschichholz Approve
Robert Dyer (community) Approve
Review via email: mp+26871@code.staging.launchpad.net

This proposal supersedes a proposal from 2010-06-05.

Commit message

add "music player daemon" helper working with sonata, gmpc, ario and gbemol

Description of the change

This adds a mpd control helper. The script also grabs the multimedia keys.

Its functioning depends on python-mpd. The script quits if that isn't satisfied.

I'm re-proposing the merge, as it seems there was some problem with the old branch.

To post a comment you must log in.
Revision history for this message
Robert Dyer (psybers) wrote : Posted in a previous version of this proposal

Your .info file is no longer correct syntax. Please merge lp:dockmanager and take a look at the new files.

review: Needs Fixing
Revision history for this message
Robert Dyer (psybers) wrote : Posted in a previous version of this proposal

Please remove any reference to 'docky'. I suggest renaming to 'DockManager'.

review: Needs Fixing
Revision history for this message
Robert Dyer (psybers) wrote :

The 'AppName' entry in the info file refers to an executable that should exist for this helper to be usable. I don't know if 'mpd' is such a thing, but just beware of that. If there is no general enough executable for your case, then do not include this entry in the .info file.

Revision history for this message
Felipe Morales (hel-sheep) wrote :

I figured so. As it is, the script is pretty much useless without "mpd", a background daemon that plays music. (see http://mpd.wikia.com/wiki/Music_Player_Daemon_Wiki ) If you aren't running that, you wouldn't find much use in this helper at all.

The helper connects to any MPD clients icon the user may have, as long it's supported by it (right now, it works with sonata, gmpc, ario and gbemol, which are the clients I've found in ubuntu), but those aren't really essential. The script in fact works as a standalone client, so the user can control MPD without having one of those clients running.

Revision history for this message
Robert Dyer (psybers) wrote :

Ok then if 'mpd' is the daemon and required, that seems reasonable.

Revision history for this message
Robert Dyer (psybers) :
review: Approve
Revision history for this message
Rico Tzschichholz (ricotz) wrote :

Please remove the quotes of the Icon defintion in metadata.
After that it Looks good to me.

review: Needs Fixing
Revision history for this message
Rico Tzschichholz (ricotz) wrote :

You just need to commit the changes to your branch there is no need for a further merge proposal, because this one will be updated.

lp://staging/~hel-sheep/dockmanager/mpd updated
35. By Felipe Morales

removed quotes in metadata file

Revision history for this message
Rico Tzschichholz (ricotz) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: