DockManager

Merge lp://staging/~hel-sheep/dockmanager/gnome-terminal-helper into lp://staging/dockmanager

gnome-terminal-helper
Merge into trunk

Proposed by Felipe Morales on 2010-12-10

Status:	Merged
Approved by:	Rico Tzschichholz on 2011-02-21
Approved revision:	77
Merged at revision:	93
Proposed branch:	lp://staging/~hel-sheep/dockmanager/gnome-terminal-helper
Merge into:	lp://staging/dockmanager
Diff against target:	82 lines (+73/-0) 2 files modified metadata/gnome_terminal_menus.py.info (+5/-0) scripts/gnome_terminal_menus.py (+68/-0)
To merge this branch:	bzr merge lp://staging/~hel-sheep/dockmanager/gnome-terminal-helper
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Rico Tzschichholz		2010-12-10	Disapprove on 2011-02-21
Review via email: mp+43315@code.staging.launchpad.net

Description of the change

This helper adds the ability to launch new gnome-terminal profile windows.
This is useful for having launchers-of-sorts for terminal applications in the dock.

Revision history for this message

Rico Tzschichholz (ricotz) wrote on 2011-02-21:

Please contact Eugeny Pankov, the author of lp:~john-pankov/dockmanager/terminal-helper
( https://code.launchpad.net/~john-pankov/dockmanager/terminal-helper/+merge/49838 )

I will disapprove this merge for now and consider the new branch for inclusion since Eugeny Pankov seems to be the real author ( http://www.omgubuntu.co.uk/2010/06/docky-terminal-helper-gives-quick-access-to-terminal-profiles-from-docky/ )

review: Disapprove

Revision history for this message

Felipe Morales (hel-sheep) wrote on 2011-02-23:

Hi. I will contact Eugeny Pankov, but from a quick glance at the scripts code, it's quite clear the implementations are different. It seems to me that both Eugeny and me had the same idea for a script; I want to make clear that I didn't copy his code or stole his idea, as seems to be suggested. I developed my script on December 2010 (as you can see from the branch changes), so it seems (from the date of the blog post Rico linked, which I hadn't seen before) that Eugeny's predates it. However, he didn't propose it until February 15th this year, while I did on December 2010. I didn't receive any news from this until now.

Anyway, I have no opinion on which script is best, though I think my procedure to get the terminal profile names is cleaner; whichever is accepted is fine for me.