qakit

Merge lp://staging/~heber013/qakit/adding-juju-bootstrapping into lp://staging/qakit

  1. adding-juju-bootstrapping
  2. Merge into trunk
Proposed by Heber Parrucci
Status: Merged
Approved by: Max Brustkern
Approved revision: 228
Merged at revision: 228
Proposed branch: lp://staging/~heber013/qakit/adding-juju-bootstrapping
Merge into: lp://staging/qakit
Diff against target: 456 lines (+421/-0)
7 files modified
qakit/juju/README.rst (+19/-0)
qakit/juju/__init__.py (+18/-0)
qakit/juju/hosts (+5/-0)
qakit/juju/juju_bootstrap (+105/-0)
qakit/juju/juju_bootstrap.py (+213/-0)
qakit/juju/mk-venv (+60/-0)
qakit/juju/requirements.txt (+1/-0)
To merge this branch: bzr merge lp://staging/~heber013/qakit/adding-juju-bootstrapping
Reviewer Review Type Date Requested Status
Max Brustkern (community) Approve
Review via email: mp+320869@code.staging.launchpad.net

Commit message

Adding juju bootstrapping

Description of the change

Automate bootstrapping for cloud, controller and model in the host machine using juju.

To test it, you need the file that contains the credentials for the cloud provider.
Example:

if your credentials file is: $HOME/.canonistack/novarc

Then run:

./juju_bootstrap --cloud_name ^THE_NAME_YOU_LIKE^ --nova_file "$HOME/.canonistack/novarc"

Too see instructions in details refer to README.rst

The script was implemented in part using subprocess because python juju clients have several bugs and limitations. I tested these clients:
- jujuclient
- juju

To post a comment you must log in.
lp://staging/~heber013/qakit/adding-juju-bootstrapping updated
220. By Heber Parrucci

Fixing relative paths in scripts

221. By Heber Parrucci

updating README.rst

222. By Heber Parrucci

Fixing relative paths when executing the script

223. By Heber Parrucci

Ensuring the nova key is always created

224. By Heber Parrucci

Adding check if bootstrap command failed

225. By Heber Parrucci

Adding proper ip range for scaling stack hosts

Revision history for this message
Max Brustkern (nuclearbob) wrote :

I've got a variety of diff comments and questions, many of which are concerned with the potential to duplicate config options or interfere with existing setups.

Revision history for this message
Heber Parrucci (heber013) wrote :

Thanks for the review!!! All comments addressed. Check replies inline for details.

lp://staging/~heber013/qakit/adding-juju-bootstrapping updated
226. By Heber Parrucci

Addressing review feedback

227. By Heber Parrucci

minor indentation change

Revision history for this message
Max Brustkern (nuclearbob) wrote :

Awesome, thanks for all the changes! One question about the placement of the new --replace argument, but other than that, I think it looks good.

Revision history for this message
Heber Parrucci (heber013) wrote :

Fixing:
* review comment when parsing replace parameter
* logging
* added logic so if replace parameter is set and the controller is bootstrapped it will delete it first before proceeding.

lp://staging/~heber013/qakit/adding-juju-bootstrapping updated
228. By Heber Parrucci

Fixing:
* review comment when parsing replace parameter
* logging
* added logic so if replace parameter is set and the controller is bootstrapped it will delete it first before proceeding.

Revision history for this message
Max Brustkern (nuclearbob) wrote :

Looks good! Let's land it!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches