Merge lp://staging/~heber013/qakit/adding-image-metadata-option into lp://staging/qakit

Proposed by Heber Parrucci
Status: Merged
Approved by: Max Brustkern
Approved revision: 230
Merged at revision: 230
Proposed branch: lp://staging/~heber013/qakit/adding-image-metadata-option
Merge into: lp://staging/qakit
Diff against target: 183 lines (+73/-15)
2 files modified
qakit/juju/juju_bootstrap (+21/-0)
qakit/juju/juju_bootstrap.py (+52/-15)
To merge this branch: bzr merge lp://staging/~heber013/qakit/adding-image-metadata-option
Reviewer Review Type Date Requested Status
Max Brustkern (community) Approve
Review via email: mp+321461@code.staging.launchpad.net

Commit message

Adding --image option to bootstrap to allow the option of generating metadata
Also delete files/dirs at the end of execution.

Description of the change

Add the option for generating image metadata in juju script.
Also deleting files/dirs created during the setup

To post a comment you must log in.
Revision history for this message
Max Brustkern (nuclearbob) wrote :

I'd consider using a finally clause in the try block instead of having the delete in the try and the except, but that's just a stylistic thing; should be good to land either way.

review: Approve
230. By Heber Parrucci

Adding finally clause for deleting files/dirs

Revision history for this message
Heber Parrucci (heber013) wrote :

Adding finally clause for deleting files/dirs

Revision history for this message
Max Brustkern (nuclearbob) wrote :

Looks good to me!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches