OpenERP Community Backports (Addons)

Merge lp://staging/~hbrunn/ocb-addons/6.1-lp1052785 into lp://staging/ocb-addons/6.1

  1. 6.1-lp1052785
  2. Merge into 6.1
Proposed by Holger Brunn (Therp)
Status: Needs review
Proposed branch: lp://staging/~hbrunn/ocb-addons/6.1-lp1052785
Merge into: lp://staging/ocb-addons/6.1
Diff against target: 14 lines (+4/-0)
1 file modified
hr_expense/hr_expense.py (+4/-0)
To merge this branch: bzr merge lp://staging/~hbrunn/ocb-addons/6.1-lp1052785
Reviewer Review Type Date Requested Status
Pedro Manuel Baeza code review Approve
Review via email: mp+242693@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Is address_home_id required? If not, you should check if exists before accessing its partner_id property.

Reply
Revision history for this message
Holger Brunn (Therp) (hbrunn) wrote :

It's not, but a couple of lines further above he raises an exception if exp.employee_id.address_home_id or exp.employee_id.address_home_id.partner_id are falsy

Reply
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

OK then.

review: Approve (code review)
Reply

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches