pyjuju

Merge lp://staging/~hazmat/pyjuju/security-policy-with-topology into lp://staging/pyjuju

Proposed by Kapil Thangavelu on 2011-08-04

Status:

Approved

Approved by:

Gustavo Niemeyer on 2011-08-10

Approved revision:

324

Proposed branch:

Merge into:

Prerequisite:

Diff against target:

2 files modified

juju/state/security.py (+17/-2)
juju/state/tests/test_security.py (+54/-2)

To merge this branch:

bzr merge lp://staging/~hazmat/pyjuju/security-policy-with-topology

Low

In Progress

Link a bug report

Reviewer	Date Requested	Status
Benjamin Saller (community)		Approve on 2011-08-10
Gustavo Niemeyer	2011-08-04	Approve on 2011-08-10
Review via email: mp+70488@code.staging.launchpad.net

security policies now have a topology accessor for rules and can be created or applied with a modified topology.

318. By Kapil Thangavelu on 2011-08-05: Merged states-with-principals into security-policy-with-topology.
319. By Kapil Thangavelu on 2011-08-05: Merged states-with-principals into security-policy-with-topology.
320. By Kapil Thangavelu on 2011-08-05: Merged states-with-principals into security-policy-with-topology.
321. By Kapil Thangavelu on 2011-08-05: Merged states-with-principals into security-policy-with-topology.
322. By Kapil Thangavelu on 2011-08-08: Merged states-with-principals into security-policy-with-topology.
323. By Kapil Thangavelu on 2011-08-08: Merged states-with-principals into security-policy-with-topology.
324. By Kapil Thangavelu on 2011-08-08: resurrect policy.get_token earlier into branch pipeline, yank policy.client access.
325. By Kapil Thangavelu on 2011-08-10: Merged states-with-principals into security-policy-with-topology.

Revision history for this message

Gustavo Niemeyer (niemeyer) wrote on 2011-08-10:

This looks good. +1, assuming the pre-req is sorted.

review: Approve

Revision history for this message

Benjamin Saller (bcsaller) wrote on 2011-08-10:

This looks good to me. As we talked about I think its good policy that we allow the topology to be passed as an argument here.

Also, I like the way this test works

+ def test_policy_with_given_topology(self):

review: Approve

326. By Kapil Thangavelu on 2011-08-17: merge trunk and resolve conflict
327. By Kapil Thangavelu on 2012-03-31: merge trunk
328. By Kapil Thangavelu on 2012-03-31: Merged states-with-principals into security-policy-with-topology.
329. By Kapil Thangavelu on 2012-04-02: merge states-with-principals

329. By Kapil Thangavelu on 2012-04-02: merge states-with-principals
328. By Kapil Thangavelu on 2012-03-31: Merged states-with-principals into security-policy-with-topology.
327. By Kapil Thangavelu on 2012-03-31: merge trunk
326. By Kapil Thangavelu on 2011-08-17: merge trunk and resolve conflict
325. By Kapil Thangavelu on 2011-08-10: Merged states-with-principals into security-policy-with-topology.
324. By Kapil Thangavelu on 2011-08-08: resurrect policy.get_token earlier into branch pipeline, yank policy.client access.
323. By Kapil Thangavelu on 2011-08-08: Merged states-with-principals into security-policy-with-topology.
322. By Kapil Thangavelu on 2011-08-08: Merged states-with-principals into security-policy-with-topology.
321. By Kapil Thangavelu on 2011-08-05: Merged states-with-principals into security-policy-with-topology.
320. By Kapil Thangavelu on 2011-08-05: Merged states-with-principals into security-policy-with-topology.