Merge lp://staging/~hazmat/pyjuju/maas-tags-redux into lp://staging/pyjuju

Proposed by Kapil Thangavelu
Status: Merged
Merged at revision: 616
Proposed branch: lp://staging/~hazmat/pyjuju/maas-tags-redux
Merge into: lp://staging/pyjuju
Diff against target: 133 lines (+34/-9)
5 files modified
juju/lib/serializer.py (+3/-1)
juju/machine/tests/test_constraints.py (+1/-0)
juju/providers/maas/provider.py (+2/-2)
juju/providers/maas/tests/test_provider.py (+28/-4)
juju/unit/lifecycle.py (+0/-2)
To merge this branch: bzr merge lp://staging/~hazmat/pyjuju/maas-tags-redux
Reviewer Review Type Date Requested Status
Juju Engineering Pending
Review via email: mp+148876@code.staging.launchpad.net

Description of the change

Fix broken maas-tags constraint.

The maas tags wasn't properly converting values for comparision
and was not previously testing tag constraint comparisons.

To post a comment you must log in.
Revision history for this message
Kapil Thangavelu (hazmat) wrote :

Please take a look.

Revision history for this message
Kapil Thangavelu (hazmat) wrote :

*** Submitted:

Fix broken maas-tags constraint.

The maas tags wasn't properly converting values for comparision
and was not previously testing tag constraint comparisons.

Revision history for this message
Martin Packman (gz) wrote :

This looks like a straight revert of r597 which confuses me somewhat. Does this mean bug 1064734 is unfixed by this change, or have we changed something since?

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: