Merge lp://staging/~hazmat/gwacl/azure-new-instances-and-regions into lp://staging/gwacl

Proposed by Kapil Thangavelu
Status: Merged
Merged at revision: 239
Proposed branch: lp://staging/~hazmat/gwacl/azure-new-instances-and-regions
Merge into: lp://staging/gwacl
Diff against target: 458 lines (+300/-13)
3 files modified
management_base.go (+1/-1)
rolesizes.go (+293/-11)
rolesizes_test.go (+6/-1)
To merge this branch: bzr merge lp://staging/~hazmat/gwacl/azure-new-instances-and-regions
Reviewer Review Type Date Requested Status
Andrew Wilkins (community) Approve
Review via email: mp+243212@code.staging.launchpad.net

Description of the change

Add missing instance types (D1-D14 and G1-G5) and regions (US Central, Australia x 2) and updating costs with latest extant. The G series aren't publicly available (private beta it seems), but there has been a request to enable it. I'm doing so speculatively for the G5 in two regions.

To post a comment you must log in.
Revision history for this message
Kapil Thangavelu (hazmat) wrote :

associated to bug http://pad.lv/1389422

Revision history for this message
Andrew Wilkins (axwalk) wrote :

LGTM with extra region. Can you please run "make format" before landing? I'd prefer gofmt, but that's how it is for now.

review: Approve
Revision history for this message
Kapil Thangavelu (hazmat) wrote :

thanks for the catch re region and test. it looks like the make format is broken with go1.3 as gofmt (which it uses) doesn't support the --tabs/--tab-spaces options anymore. i've rebuilt an older version of go for now but its likely to come up again and i'd suggest we just switch out to standard gofmt.

240. By Kapil Thangavelu

add in us east 2 to unit tests, reformat with old version of gofmt per project style

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches