Merge lp://staging/~hatch/juju-gui/service-name-1252578 into lp://staging/juju-gui/experimental
Proposed by
Jeff Pihach
Status: | Merged |
---|---|
Merged at revision: | 1218 |
Proposed branch: | lp://staging/~hatch/juju-gui/service-name-1252578 |
Merge into: | lp://staging/juju-gui/experimental |
Diff against target: |
182 lines (+106/-9) 4 files modified
app/views/ghost-inspector.js (+13/-9) app/views/utils.js (+14/-0) test/test_ghost_inspector.js (+19/-0) test/test_utils.js (+60/-0) |
To merge this branch: | bzr merge lp://staging/~hatch/juju-gui/service-name-1252578 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Juju GUI Hackers | Pending | ||
Review via email:
|
Description of the change
Validates the service names on user entry
The service name input field in the ghost inspector now validates
against a similar regex that is used in juju-core to avoid failures
trying to deploy services.
To post a comment you must log in.
Reviewers: mp+197543_ code.launchpad. net,
Message:
Please take a look.
Description:
Validates the service names on user entry
The service name input field in the ghost inspector now validates
against a similar regex that is used in juju-core to avoid failures
trying to deploy services.
To QA:
Add a service to the canvas
Try to deploy the service using the values provided in the included
tests
https:/ /code.launchpad .net/~hatch/ juju-gui/ service- name-1252578/ +merge/ 197543
(do not edit description out of merge proposal)
Please review this at https:/ /codereview. appspot. com/36500044/
Affected files (+106, -8 lines): ghost-inspector .js ghost_inspector .js
A [revision details]
M app/views/
M app/views/utils.js
M test/test_
M test/test_utils.js