Juju Charms Collection
juju-gui package

Merge lp://staging/~hatch/charms/trusty/juju-gui/firefox-cert-fix into lp://staging/~juju-gui/charms/trusty/juju-gui/trunk

  1. Trusty Tahr (14.04)
  2. firefox-cert-fix
  3. Merge into trunk
Proposed by Jeff Pihach
Status: Merged
Approved by: Jeff Pihach
Approved revision: 256
Merged at revision: 256
Proposed branch: lp://staging/~hatch/charms/trusty/juju-gui/firefox-cert-fix
Merge into: lp://staging/~juju-gui/charms/trusty/juju-gui/trunk
Diff against target: 25 lines (+3/-1)
1 file modified
hooks/utils.py (+3/-1)
To merge this branch: bzr merge lp://staging/~hatch/charms/trusty/juju-gui/firefox-cert-fix
Reviewer Review Type Date Requested Status
Richard Harding Approve
Review via email: mp+258561@code.staging.launchpad.net

Description of the change

Fixes https://bugs.launchpad.net/juju-gui/+bug/1397296 by adding a unique integer to the certificate name.

To QA deploy the charm and visit in firefox. When visiting for the first time ensure that the generated certificate name follows the format your-jujugui-########.local

To post a comment you must log in.
Revision history for this message
Richard Harding (rharding) wrote :

LGTM with QA of loading it and deploying it to ec2.

From the SSL details:
The certificate is only valid for your-jujugui-1431034422.local

It then loaded properly and functioned.

Small fix here so feel free to land.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: