Merge lp://staging/~harlowja/cloud-init/launch-index-work into lp://staging/~cloud-init-dev/cloud-init/trunk
Proposed by
Scott Moser
Status: | Merged |
---|---|
Merged at revision: | 642 |
Proposed branch: | lp://staging/~harlowja/cloud-init/launch-index-work |
Merge into: | lp://staging/~cloud-init-dev/cloud-init/trunk |
Diff against target: |
365 lines (+196/-29) 8 files modified
cloudinit/cloud.py (+6/-2) cloudinit/filters/__init__.py (+21/-0) cloudinit/filters/launch_index.py (+75/-0) cloudinit/sources/DataSourceEc2.py (+6/-0) cloudinit/sources/__init__.py (+25/-3) cloudinit/stages.py (+1/-1) cloudinit/user_data.py (+54/-18) cloudinit/util.py (+8/-5) |
To merge this branch: | bzr merge lp://staging/~harlowja/cloud-init/launch-index-work |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
cloud-init Commiters | Pending | ||
Review via email:
|
To post a comment you must log in.
Josh, LAUNCH_ INDEX ? /review. openstack. org/#/c/ 11997/ will add 'launch_index' to the openstack metadata service. I suggest we make the getter for launch_index a default in DataSource and let ec2 override it. The default would look for 'launch_index' or 'launch-index' in metadata and return None if not found.
Thanks for the work, it looks pretty good. I have a few comments:
* why CAN_HAVE_
why do we want to limit which parts can affect only a given launch index.
* https:/