lazr.restfulclient

Merge lp://staging/~gz/lazr.restfulclient/python_2.4_compatibility into lp://staging/lazr.restfulclient

  1. python_2.4_compatibility
  2. Merge into trunk
Proposed by Martin Packman
Status: Merged
Approved by: Gavin Panella
Approved revision: 100
Merged at revision: 111
Proposed branch: lp://staging/~gz/lazr.restfulclient/python_2.4_compatibility
Merge into: lp://staging/lazr.restfulclient
Diff against target: 15 lines (+4/-1)
1 file modified
src/lazr/restfulclient/resource.py (+4/-1)
To merge this branch: bzr merge lp://staging/~gz/lazr.restfulclient/python_2.4_compatibility
Reviewer Review Type Date Requested Status
Gavin Panella Approve
Review via email: mp+25717@code.staging.launchpad.net

Description of the change

Installed launchpadlib just now and launchpadlib.launchpad failed to import because lazr.restfulclient uses the new PEP-8 happy "email.message" spelling rather than the Python 2.4 compatible "email.Message" spelling.

Unrelated complaint: is the bootstrap.py symlink really necessary? Makes branching this project a pain.

To post a comment you must log in.
Revision history for this message
Gavin Panella (allenap) wrote :

Thanks for fixing this, +1.

> Unrelated complaint: is the bootstrap.py symlink really necessary?
> Makes branching this project a pain.

I assume you're using Windows? Out of interest, what happens?

Please file a bug about this, there's no reason why we shouldn't fix
it.

review: Approve
Revision history for this message
Leonard Richardson (leonardr) wrote :

I'm also +1 on this code, I've verified that the tests pass (in 2.6, I don't have 2.4 handy), and will land.

Revision history for this message
Martin Packman (gz) wrote :

Thanks! I filed bug 671135 on the symlink annoyance.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches