Merge lp://staging/~gz/juju-release-tools/test_apply_patches into lp://staging/juju-release-tools

Proposed by Martin Packman
Status: Superseded
Proposed branch: lp://staging/~gz/juju-release-tools/test_apply_patches
Merge into: lp://staging/juju-release-tools
Diff against target: 297 lines (+196/-14)
6 files modified
apply_patches.py (+12/-7)
tests/__init__.py (+4/-0)
tests/test_apply_patches.py (+166/-0)
tests/test_build_package.py (+3/-1)
tests/test_crossbuild.py (+3/-1)
utils.py (+8/-5)
To merge this branch: bzr merge lp://staging/~gz/juju-release-tools/test_apply_patches
Reviewer Review Type Date Requested Status
Juju Release Engineering Pending
Review via email: mp+300775@code.staging.launchpad.net

This proposal has been superseded by a proposal from 2016-07-21.

Commit message

Add test coverage for apply_patches script

Description of the change

Somehow I forgot on Friday that we do actually have test infrastructure for juju-release-tools, so this branch adds coverage. There are some fiddly bits (`with open` is always annoying), and one relevent change with the addition of flushing for the parent process's output. This ensures the ordering of output is correct when mixed with the patch command, which currently is a confusion on the logs.

The addition of gettext for the user informational output is total vanity. Please forgive.

To post a comment you must log in.
323. By Martin Packman

Switch to using stderr for apply_patches output

324. By Martin Packman

Remove mostly redundant test for apply_patches

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches