juju-release-tools

Merge lp://staging/~gz/juju-release-tools/check_deps_delete into lp://staging/juju-release-tools

check_deps_delete
Merge into trunk

Proposed by Martin Packman on 2015-05-01

Status:	Merged
Merged at revision:	179
Proposed branch:	lp://staging/~gz/juju-release-tools/check_deps_delete
Merge into:	lp://staging/juju-release-tools
Diff against target:	236 lines (+133/-25) 4 files modified check_dependencies.py (+19/-8) make-release-tarball.bash (+15/-16) tests/test_check_dependencies.py (+98/-0) tests/test_make_release_notes.py (+1/-1)
To merge this branch:	bzr merge lp://staging/~gz/juju-release-tools/check_deps_delete
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Curtis Hovey (community)	code	2015-05-01	Approve on 2015-05-01
Review via email: mp+258042@code.staging.launchpad.net

Description of the change

Switch check_dependencies to delete unknown packages in tree

We've had various pain from accidentially pulling in non-dependencies to our tarball due to godeps being recursively promiscuous. Rather than failing out and making the core unlandable, delete any undeclared dependencies that get pulled in, and trust testing to catch deps that were actually required.

At some point this script should be combined with deptree which has a little more structure, and also does some dependencies.tsv parsing and a few other common features.

lp://staging/~gz/juju-release-tools/check_deps_delete updated on 2015-05-01

179. By Martin Packman on 2015-05-01: New --delete-unknown flag to check_dependencies script

Revision history for this message

Martin Packman (gz) wrote on 2015-05-01:

Repushed with fix and tarball script rearrangement.

Rog is also aiming to solve this issue in godeps:

<https://codereview.appspot.com/230460044/>

Revision history for this message

Curtis Hovey (sinzui) wrote on 2015-05-01:

Thank you. Why does the script still need rules to delete
github.com/kisielk

I think the delete rule will see one or more packages owned by kisielk and delete them.

review: Approve (code)

Revision history for this message

Martin Packman (gz) wrote on 2015-05-01:

Indeed it would delete the packages inside kisielk, I manually tested that aspect as well.

However, one of Oleg's question marks on packaging review was why we had an empty directory there, which remains because that's the github user, which then contains the projects. It's harmless to delete it.