juju-release-tools

Merge lp://staging/~gz/juju-release-tools/check_deps_1368417 into lp://staging/juju-release-tools

  1. check_deps_1368417
  2. Merge into trunk
Proposed by Martin Packman
Status: Merged
Merged at revision: 64
Proposed branch: lp://staging/~gz/juju-release-tools/check_deps_1368417
Merge into: lp://staging/juju-release-tools
Diff against target: 91 lines (+69/-0)
2 files modified
check_dependencies.py (+64/-0)
make-release-tarball.bash (+5/-0)
To merge this branch: bzr merge lp://staging/~gz/juju-release-tools/check_deps_1368417
Reviewer Review Type Date Requested Status
Curtis Hovey (community) code Approve
Review via email: mp+235035@code.staging.launchpad.net

Description of the change

Validate go src tree against dependencies.tsv before finishing make-release-tarball script

Adds a new python script `check_dependencies.py` for gating the tarball construction on having all go packages in the tarball listed in dependencies.tsv - and all listed dependencies present. This is not totally robust, but the included logic seems reasonable. Basically, walk the tree and compare directories with files against the listed paths. Plus some magic for dotted suffixes used as versioning on some packages.

In addition, cleans out 'github.com/kisielk/gotool' which is a godeps only dependency.

To post a comment you must log in.
Revision history for this message
Curtis Hovey (sinzui) wrote :

Thank you. You can merge this after you add some periods or punctuation of your choice to the ends some of the doc comments.

review: Approve (code)
lp://staging/~gz/juju-release-tools/check_deps_1368417 updated
64. By Martin Packman

Lint and docstring punctuation

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches