Merge lp://staging/~gz/bzr-windows-installers/upload_with_launchpadlib into lp://staging/bzr-windows-installers

Proposed by Martin Packman
Status: Merged
Merged at revision: 201
Proposed branch: lp://staging/~gz/bzr-windows-installers/upload_with_launchpadlib
Merge into: lp://staging/bzr-windows-installers
Diff against target: 127 lines (+35/-56)
1 file modified
upload_to_launchpad.py (+35/-56)
To merge this branch: bzr merge lp://staging/~gz/bzr-windows-installers/upload_with_launchpadlib
Reviewer Review Type Date Requested Status
Bazaar Developers Pending
Review via email: mp+89962@code.staging.launchpad.net

Description of the change

The upload_to_launchpad.py script stopped working, as according to wgrant Basic auth was disabled a week or so ago. He pointed me at the right area of the launchpad api instead, which this branch updates the script to use instead. The main differences are than instead of needing to type your sso password three times, there's the once-off browser auth step, which is good. Also, the whole file gets wrapped in a mime message in python and there's no progress indicator any more, which is bad. Don't think that can be improved on unfortunately. However, the prospect of doing a full upload just to have it rejected is gone at least.

Thought I'd pushed this on Friday, but apparently not. So, merge proposal instead so that interested parties can see the diff.

To post a comment you must log in.
Revision history for this message
Martin Pool (mbp) wrote :

Could you have a look at putting a generalized form of this into
lptools, if generalizing it is not too much work?

Revision history for this message
Martin Packman (gz) wrote :

I was referring to a more generalised form in lptools to write this. That only expects tarballs, but does much more around creating releases and adding the metadata, whereas this really just does some bzr-specific logic then splats the files.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches