Merge lp://staging/~gz/bzr-windows-installers/include_manifest_in_installer_632465 into lp://staging/bzr-windows-installers
Status: | Superseded |
---|---|
Proposed branch: | lp://staging/~gz/bzr-windows-installers/include_manifest_in_installer_632465 |
Merge into: | lp://staging/bzr-windows-installers |
Diff against target: |
41 lines (+15/-2) 2 files modified
build.py (+14/-2) templates/inno/bzr.iss (+1/-0) |
To merge this branch: | bzr merge lp://staging/~gz/bzr-windows-installers/include_manifest_in_installer_632465 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Bazaar Developers | Pending | ||
Review via email:
|
This proposal has been superseded by a proposal from 2010-10-16.
Description of the change
Makes sure people without the VC 9 runtime libraries installed can still use the all-in-one installer by bundling the manifest. Also puts it and the library in a suitabily named subdirectory as suggested by the py2exe tutorial on this stuff.
As I'm not sure if we're still building installers with this code for Python 2.5 I made sure that'd still work by adding the old msvcr71.dll if it's available. Ideally these would be templated sections and we'd pass in the actual Python version used, but this should do for now.
Note, the SxS libraries seem to take precedence over the bundled libraries anyway, so to test this you either need to mess around in your Windows directory or use a non-development machine without the runtime libraries installed.
I don't know if it's right, but it doesn't look wrong.