Merge lp://staging/~gz/bzr-builder/trivial_test_file_contents into lp://staging/bzr-builder
Proposed by
Martin Packman
| Status: | Merged |
|---|---|
| Approved by: | Jelmer Vernooij |
| Approved revision: | 146 |
| Merged at revision: | 147 |
| Proposed branch: | lp://staging/~gz/bzr-builder/trivial_test_file_contents |
| Merge into: | lp://staging/bzr-builder |
| Diff against target: |
126 lines (+27/-40) 1 file modified
tests/test_blackbox.py (+27/-40) |
| To merge this branch: | bzr merge lp://staging/~gz/bzr-builder/trivial_test_file_contents |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Jelmer Vernooij (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Slightly reduce amount of boilerplate in test_blackbox changelog tests. Would like to be a bit cleverer about this, but presume we need to work with older testtools versions. So, just creates a helper to read file contents to save copying the try/finally around everywhere that can't assert about the entire file contents.
To post a comment you must log in.
Revision history for this message
| Jelmer Vernooij (jelmer) | # |
review:
Approve
Revision history for this message
| Jelmer Vernooij (jelmer) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
rock on.