Merge lp://staging/~gz/bzr-builddeb/merge_changelog_invalid_version_tweak_testing into lp://staging/bzr-builddeb
Proposed by
Martin Packman
| Status: | Superseded |
|---|---|
| Proposed branch: | lp://staging/~gz/bzr-builddeb/merge_changelog_invalid_version_tweak_testing |
| Merge into: | lp://staging/bzr-builddeb |
| Diff against target: |
175 lines (+68/-13) (has conflicts) 1 file modified
tests/test_merge_changelog.py (+68/-13) Text conflict in tests/test_merge_changelog.py |
| To merge this branch: | bzr merge lp://staging/~gz/bzr-builddeb/merge_changelog_invalid_version_tweak_testing |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| James Westby | Approve | ||
|
Review via email:
|
|||
This proposal has been superseded by a proposal from 2011-12-14.
Description of the change
Follow up to previous mp, tidying up the merge_changelog testing a little:
<https:/
Original way of spelling the test meant it would fail when selftest was run with LANG=de_DE.UTF-8 for example. Have rearranged things a bit to make it easy to add another test for the original style of invalid version as well.
To post a comment you must log in.
Unmerged revisions
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Hi,
Thanks for cleaning this up. It looks good to me, assuming the
conflicts are easily resolvable.
Thanks,
James