Merge lp://staging/~gunchleoc/widelands/mapobject_cleanup into lp://staging/widelands

Proposed by GunChleoc
Status: Merged
Merged at revision: 7112
Proposed branch: lp://staging/~gunchleoc/widelands/mapobject_cleanup
Merge into: lp://staging/widelands
Diff against target: 274 lines (+17/-53)
12 files modified
src/logic/building.cc (+0/-11)
src/logic/building.h (+0/-1)
src/logic/constructionsite.cc (+3/-3)
src/logic/dismantlesite.cc (+1/-1)
src/logic/partially_finished_building.cc (+0/-13)
src/logic/partially_finished_building.h (+0/-1)
src/logic/player.cc (+1/-1)
src/logic/soldier.cc (+5/-5)
src/logic/worker.cc (+3/-3)
src/logic/worker.h (+1/-11)
src/wui/buildingwindow.cc (+1/-1)
src/wui/productionsitewindow.cc (+2/-2)
To merge this branch: bzr merge lp://staging/~gunchleoc/widelands/mapobject_cleanup
Reviewer Review Type Date Requested Status
SirVer Approve
Review via email: mp+226804@code.staging.launchpad.net

Description of the change

More Map_Object_Descr cleanup

To post a comment you must log in.
Revision history for this message
SirVer (sirver) wrote :

Looks good.

review: Needs Fixing
Revision history for this message
SirVer (sirver) wrote :

... but couple of comments :).

review: Needs Fixing
Revision history for this message
GunChleoc (gunchleoc) wrote :

The first 2 comments are dealt with. For the last one, I need a code sample in https://bugs.launchpad.net/widelands/+bug/1203629

Revision history for this message
GunChleoc (gunchleoc) wrote :

Let's skip the last one and merge, since I'll take on the other bug anyway.

Revision history for this message
SirVer (sirver) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: