widelands

Merge lp://staging/~gunchleoc/widelands/bug-1818494-ingame-zoom-freezes into lp://staging/widelands

  1. bug-1818494-ingame-zoom-freezes
  2. Merge into trunk
Proposed by GunChleoc
Status: Merged
Merged at revision: 9024
Proposed branch: lp://staging/~gunchleoc/widelands/bug-1818494-ingame-zoom-freezes
Merge into: lp://staging/widelands
Diff against target: 61 lines (+20/-0)
2 files modified
src/wui/mapview.cc (+16/-0)
src/wui/mapview.h (+4/-0)
To merge this branch: bzr merge lp://staging/~gunchleoc/widelands/bug-1818494-ingame-zoom-freezes
Reviewer Review Type Date Requested Status
Benedikt Straub Approve
Review via email: mp+364304@code.staging.launchpad.net

Commit message

Skip calculating changes to the map view's viewport when nothing would change. This prevents the map view from being busy when the user leans on the CTRL+/- keys.

Description of the change

I think this should go into Build 20, because it can make the player think that Widelands has crashed, while it's just the mapview being busy.

To post a comment you must log in.
Revision history for this message
bunnybot (widelandsofficial) wrote :

Continuous integration builds have changed state:

Travis build 4610. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/508054518.
Appveyor build 4397. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_gunchleoc_widelands_bug_1818494_ingame_zoom_freezes-4397.

Revision history for this message
GunChleoc (gunchleoc) wrote :

Just bumping this review. I'd like this branch in Build 20 to avoid getting bug reports when Widelands seems to freeze.

Revision history for this message
Benedikt Straub (nordfriese) wrote :

Code LGTM, works as expected.
Thanks for fixing this nasty bug :)

review: Approve
Revision history for this message
GunChleoc (gunchleoc) wrote :

Thanks for the review :)

@bunnybot merge

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: