widelands

Merge lp://staging/~gunchleoc/widelands/bug-1619157-random-ai-none into lp://staging/widelands

  1. bug-1619157-random-ai-none
  2. Merge into trunk
Proposed by GunChleoc
Status: Merged
Merged at revision: 8109
Proposed branch: lp://staging/~gunchleoc/widelands/bug-1619157-random-ai-none
Merge into: lp://staging/widelands
Diff against target: 25 lines (+2/-2)
2 files modified
src/logic/single_player_game_settings_provider.cc (+1/-1)
src/network/nethost.cc (+1/-1)
To merge this branch: bzr merge lp://staging/~gunchleoc/widelands/bug-1619157-random-ai-none
Reviewer Review Type Date Requested Status
TiborB Approve
Review via email: mp+306518@code.staging.launchpad.net

Commit message

Random AI no longer selects the empty AI.

Description of the change

Since this is clearly a regression and the fix is tiny, I am in favour of having this in Build 19.

To post a comment you must log in.
Revision history for this message
bunnybot (widelandsofficial) wrote :

Continuous integration builds have changed state:

Travis build 1350. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/161981847.
Appveyor build 1192. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_gunchleoc_widelands_bug_1619157_random_ai_none-1192.

Revision history for this message
TiborB (tiborb95) wrote :

Looks good (code + testing), It seemed that "very weak" AI is picked less then other types, but maybe it was just coincidence...

review: Approve
Revision history for this message
GunChleoc (gunchleoc) wrote :

Yes, probably just coincidence.

@bunnybot merge

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: